Skip to content

Commit ffb5793

Browse files
committed
Removed UserError. Treat invalid package.json as non-existent package.json.
1 parent 8c7032e commit ffb5793

File tree

3 files changed

+4
-21
lines changed

3 files changed

+4
-21
lines changed

src/hook.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
var semver = require( "semver" ),
22
Step = require( "step" ),
3-
UserError = require( "./user-error" ),
43
pluginsDb = require( "./pluginsdb" ),
54
service = require( "./service" ),
65
retry = require( "./retrydb" ),
@@ -134,7 +133,7 @@ function processRelease( repo, release, fn ) {
134133
if ( owner !== repo.userName ) {
135134
// TODO: report error to user
136135
logger.log( repo.userName + " attempted to add " + release.package.name + " which is owned by " + owner );
137-
return fn( new UserError( "Plugin " + release.package.name + " is owned by " + owner + "." ) );
136+
return fn( null, null );
138137
}
139138

140139
return owner;

src/service.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
var semver = require( "semver" ),
22
Step = require( "step" ),
3-
UserError = require( "./user-error" ),
43
config = require( "./config" );
54

65
function extend( a, b ) {
@@ -36,7 +35,8 @@ extend( Repo.prototype, {
3635
try {
3736
var package = JSON.parse( package );
3837
} catch( error ) {
39-
return fn( new UserError( "Could not parse package.json for " + version + "." ) );
38+
// TODO: report error to user?
39+
return fn( null, null );
4040
}
4141

4242
fn( null, package );
@@ -150,11 +150,7 @@ extend( Repo.prototype, {
150150
// check if we found a package.json
151151
function( error, package ) {
152152
if ( error ) {
153-
if ( error.userError ) {
154-
// TODO: report error to user
155-
} else {
156-
// TODO: log error for retry
157-
}
153+
// TODO: log error for retry
158154
return fn( error );
159155
}
160156

src/user-error.js

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)