Initial support for suites.

scottgonzalez · scottgonzalez · commit bbed9b4b802b · 2012-01-18T16:12:34.000-05:00
diff --git a/src/hook.js b/src/hook.js
@@ -117,6 +117,30 @@ function processVersions( repo, fn ) {
 }
 
 function processRelease( repo, release, fn ) {
+	// if this is a suite, process each plugin individually
+	if ( Array.isArray( release.package ) ) {
+		return Step(
+			function() {
+				var group = this.group();
+				release.package.forEach(function( package ) {
+					processRelease( repo, {
+						tag: release.tag,
+						package: package
+					}, group() );
+				});
+			},
+
+			function( error ) {
+				if ( error ) {
+					return fn( error );
+				}
+
+				fn( null, release );
+			}
+		);
+	}
+
+	// TODO: track plugin name for retry in suites
 	Step(
 		// find out who owns this plugin
 		// if there is no owner, then set the user as the owner
diff --git a/src/service.js b/src/service.js
@@ -2,6 +2,10 @@ var semver = require( "semver" ),
 	Step = require( "step" ),
 	config = require( "./config" );
 
+var suites = {
+	"github/rdworth/temp-jqueryui": "ui-"
+};
+
 function extend( a, b ) {
 	for ( var prop in b ) {
 		a[ prop ] = b[ prop ];
@@ -12,12 +16,18 @@ function Repo() {
 	this.userId = this.service + "/" + this.userName;
 	this.id = this.userId + "/" + this.repoName;
 	this.path = config.repoDir + "/" + this.id;
+	this.isSuite = this.id in suites;
 }
 
 // package.json
 extend( Repo.prototype, {
-	getPackageJson: function( version, fn ) {
-		this._getPackageJson( version, function( error, package ) {
+	getPackageJson: function( version, file, fn ) {
+		if ( typeof file === "function" ) {
+			fn = file;
+			file = "package.json";
+		}
+
+		this._getPackageJson( version, file, function( error, package ) {
 			if ( error ) {
 				return fn( error );
 			}
@@ -236,6 +246,10 @@ extend( Repo.prototype, {
 	},
 
 	validateVersion: function( tag, fn ) {
+		if ( this.isSuite ) {
+			return this.validateVersion_suite( tag, fn );
+		}
+
 		var repo = this;
 		Step(
 			// get the package.json
@@ -250,7 +264,7 @@ extend( Repo.prototype, {
 				}
 
 				if ( !package ) {
-					return fn( null );
+					return fn( null, null );
 				}
 
 				return package;
@@ -268,6 +282,54 @@ extend( Repo.prototype, {
 				fn( null, package );
 			}
 		);
+	},
+
+	validateVersion_suite: function( tag, fn ) {
+		var repo = this;
+		Step(
+			// get list of package.json files
+			function() {
+				repo.getPackageJsonFiles( tag, this );
+			},
+
+			// get all package.jsons
+			function( error, files ) {
+				if ( error ) {
+					return fn( error );
+				}
+
+				if ( !files.length ) {
+					return fn( null, null );
+				}
+
+				var group = this.group();
+				files.forEach(function( file ) {
+					repo.getPackageJson( tag, file, group() );
+				});
+			},
+
+			// validate package.jsons
+			function( error, packages ) {
+				if ( error ) {
+					return fn( error );
+				}
+
+				// if any package.json is invalid, then the whole version is invalid
+				if ( packages.some(function( package ) {
+					return !package;
+				})) {
+					return fn( null, null );
+				}
+
+				for ( var i = 0, l = packages.length; i < l; i++ ) {
+					if ( repo.validatePackageJson( packages[ i ], tag ).length ) {
+						return fn( null, null );
+					}
+				}
+
+				fn( null, packages );
+			}
+		);
 	}
 });
 
diff --git a/src/service/github.js b/src/service/github.js
@@ -84,9 +84,22 @@ extend( GithubRepo.prototype, {
 		);
 	},
 
-	_getPackageJson: function( version, fn ) {
+	getPackageJsonFiles: function( tag, fn ) {
+		exec( "git ls-tree " + tag + " --name-only", { cwd: this.path }, function( error, stdout, stderr ) {
+			if ( error ) {
+				return fn( error );
+			}
+
+			// filter to *.package.json
+			fn( null, stdout.split( "\n" ).filter(function( file ) {
+				return file.indexOf( ".package.json" ) > 0;
+			}));
+		});
+	},
+
+	_getPackageJson: function( version, file, fn ) {
 		version = version || "master";
-		exec( "git show " + version + ":package.json", { cwd: this.path }, function( error, stdout, stderr ) {
+		exec( "git show " + version + ":" + file, { cwd: this.path }, function( error, stdout, stderr ) {
 			// this will also result in an error being passed, so we check stderr first
 			if ( stderr && stderr.substring( 0, 11 ) === "fatal: Path" ) {
 				return fn( null, null );
