Skip to content

Commit afcdd6a

Browse files
committed
Selectmenu: cleanup unit tests, removing mass test
1 parent 4526357 commit afcdd6a

File tree

2 files changed

+26
-42
lines changed

2 files changed

+26
-42
lines changed

tests/unit/selectmenu/selectmenu_core.js

Lines changed: 25 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -4,29 +4,27 @@ module( "selectmenu: core" );
44

55
test("accessibility", function () {
66
var element = $('#speed').selectmenu(),
7-
button = element.selectmenu("widget").parent(),
8-
menu = element.selectmenu("menuWidget").parent(),
9-
link = button.find("a"),
10-
selected = element.find("option:selected"),
11-
ul = menu.children("ul");
7+
button = element.selectmenu("widget"),
8+
menu = element.selectmenu("menuWidget"),
9+
selected = element.find("option:selected");
1210

13-
link.simulate( "focus" );
14-
var links = ul.find("li.ui-menu-item a");
11+
button.simulate( "focus" );
12+
var links = menu.find("li.ui-menu-item a");
1513

1614
expect(12 + links.length * 2);
1715

18-
equals( link.attr("role"), "combobox", "button link role" );
19-
equals( link.attr("aria-haspopup"), "true", "button link aria-haspopup" );
20-
equals( link.attr("aria-expanded"), "false", "button link aria-expanded" );
21-
equals( link.attr("aria-autocomplete"), "list", "button link aria-autocomplete" );
22-
equals( link.attr("aria-owns"), ul.attr("id"), "button link aria-owns" );
23-
equals( link.attr("tabindex"), 0, "button link tabindex" );
24-
25-
equals( ul.attr("role"), "listbox", "menu role" );
26-
equals( ul.attr("aria-labelledby"), link.attr("id"), "menu aria-labelledby" );
27-
equals( ul.attr("aria-hidden"), "true", "menu aria-hidden" );
28-
equals( ul.attr("tabindex"), 0, "menu tabindex" );
29-
equals( ul.attr("aria-activedescendant"), links.eq(element[0].selectedIndex).attr("id"), "menu aria-activedescendant" );
16+
equals( button.attr("role"), "combobox", "button link role" );
17+
equals( button.attr("aria-haspopup"), "true", "button link aria-haspopup" );
18+
equals( button.attr("aria-expanded"), "false", "button link aria-expanded" );
19+
equals( button.attr("aria-autocomplete"), "list", "button link aria-autocomplete" );
20+
equals( button.attr("aria-owns"), menu.attr("id"), "button link aria-owns" );
21+
equals( button.attr("tabindex"), 0, "button link tabindex" );
22+
23+
equals( menu.attr("role"), "listbox", "menu role" );
24+
equals( menu.attr("aria-labelledby"), button.attr("id"), "menu aria-labelledby" );
25+
equals( menu.attr("aria-hidden"), "true", "menu aria-hidden" );
26+
equals( menu.attr("tabindex"), 0, "menu tabindex" );
27+
equals( menu.attr("aria-activedescendant"), links.eq(element[0].selectedIndex).attr("id"), "menu aria-activedescendant" );
3028
$.each( links, function(index){
3129
equals( $(this).attr("role"), "option", "menu link #" + index +" role" );
3230
equals( $(this).attr("tabindex"), -1, "menu link #" + index +" tabindex" );
@@ -49,39 +47,26 @@ $.each([
4947
expect(8);
5048

5149
var element = $(settings.selector).selectmenu(),
52-
button = element.selectmenu("widget").parent(),
53-
menu = element.selectmenu("menuWidget").parent(),
54-
link = button.find("a"),
55-
ul = menu.children("ul"),
50+
button = element.selectmenu("widget"),
51+
menu = element.selectmenu("menuWidget"),
5652
selected = element.find("option:selected");
5753

58-
link.simulate( "focus" )
59-
var links = ul.find("li.ui-menu-item a");
54+
button.simulate( "focus" )
55+
var links = menu.find("li.ui-menu-item a");
6056

61-
link.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } );
62-
equals( ul.attr("aria-activedescendant"), links.eq(element[0].selectedIndex).attr("id"), "after keydown menu aria-activedescendant" );
57+
button.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } );
58+
equals( menu.attr("aria-activedescendant"), links.eq(element[0].selectedIndex).attr("id"), "after keydown menu aria-activedescendant" );
6359
equals( links.eq(element[0].selectedIndex).attr("aria-selected"), "true", "after keydown selected menu link aria-selected" );
6460
equals( element.find("option:selected").val(), selected.next("option").val() , "after keydown original select state" );
6561
equals( button.text(), selected.next("option").text(), "after keydown button text" );
6662

67-
link.simulate( "click" );
63+
button.simulate( "click" );
6864
menu.find("a").last().simulate( "mouseover" ).trigger( "click" );
69-
equals( ul.attr("aria-activedescendant"), links.eq(element[0].selectedIndex).attr("id"), "after click menu aria-activedescendant" );
65+
equals( menu.attr("aria-activedescendant"), links.eq(element[0].selectedIndex).attr("id"), "after click menu aria-activedescendant" );
7066
equals( links.eq(element[0].selectedIndex).attr("aria-selected"), "true", "after click selected menu link aria-selected" );
7167
equals( element.find("option:selected").val(), element.find("option").last().val(), "after click original select state" );
7268
equals( button.text(), element.find("option").last().text(), "after click button text" );
7369
});
7470
});
7571

76-
77-
// test("mass", function () {
78-
// for (var i = 0; i < 100; i++) {
79-
// var element = $('#speed').selectmenu();
80-
// var widget = element.selectmenu("destroy");
81-
// expect(0);
82-
// }
83-
// });
84-
85-
86-
8772
})( jQuery );

tests/unit/selectmenu/selectmenu_methods.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ test("enable / disable", function () {
3232

3333
var element = $('#speed').selectmenu(),
3434
button = element.selectmenu("widget"),
35-
menu = element.selectmenu("menuWidget"),
36-
link = button.find("a");
35+
menu = element.selectmenu("menuWidget");
3736

3837
element.selectmenu("disable");
3938
ok( element.selectmenu("option", "disabled"), "disable: widget option" );

0 commit comments

Comments
 (0)