Skip to content

Commit ee0849a

Browse files
committed
Fixes based on PR feedback.
1 parent af3a81f commit ee0849a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ui/jquery.ui.dataview.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ $.widget( "ui.dataview", {
6767
return Math.ceil( this.totalCount / this.options.paging.limit );
6868
},
6969

70+
// TODO need reasonable signatures/names for callback and error.
7071
refresh: function( callback, error ) {
7172
this._trigger( "request" );
7273

ui/jquery.ui.grid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ $.widget( "ui.grid", {
228228
this._container().children().each(function() {
229229
if ( $( this ).data( "grid-item" ) === item ) {
230230
// TODO Client code may rely on stable TRs for simple property updates. This was: $( this ).replaceWith( that._newRow( item ) );
231-
$( this ).html( that._newRow( item ).html() );
231+
$( this ).html( that._newRow( item ) );
232232
}
233233
});
234234
this._trigger( "refresh" );

ui/jquery.ui.observable.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@
99

1010
var splice = [].splice;
1111

12-
function observable( data ) {
12+
var observable = $.observable.Observable = function ( data ) {
1313
this.data = data;
1414
}
15+
1516
observable.prototype = {
1617
data: null,
1718

@@ -164,8 +165,6 @@
164165
}
165166
};
166167

167-
$.observable.Observable = observable;
168-
169168
$.each({ bind: "bind", unbind: "unbind", _trigger: "triggerHandler" }, function( from, to ) {
170169
observable.prototype[ from ] = function() {
171170
var wrapped = $([ this.data ]);

0 commit comments

Comments
 (0)