Skip to content

Commit 58d0aa3

Browse files
committed
Move .type to be a function on CSSNumericValue, and have an issue to figure out how to define it.
1 parent 7dd1741 commit 58d0aa3

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

css-typed-om/Overview.bs

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -598,11 +598,15 @@ are represented by subclasses of the {{CSSNumericValue}} interface.
598598
boolean equals(CSSNumberish... value);
599599

600600
CSSNumericValue to(DOMString unit);
601+
// ??? type();
601602

602603
static CSSNumericValue parse(DOMString cssText);
603604
};
604605
</xmp>
605606

607+
Issue: Figure out how we want to represent the type of an expression in JS,
608+
and define the type() method accordingly.
609+
606610
The methods on the {{CSSNumericValue}} superclass
607611
represent operations that all numeric values can perform.
608612

@@ -1241,13 +1245,6 @@ are represented as {{CSSUnitValue}}s.
12411245
it must return the value of |this|’s {{CSSUnitValue/unit}} internal slot.
12421246
</div>
12431247

1244-
<div algorithm="CSSUnitValue.type">
1245-
The <dfn attribute for=CSSUnitValue>type</dfn> attribute of a {{CSSUnitValue}} |this| must,
1246-
on reading,
1247-
1248-
Issue: Figure out how we're exposing types. This should probably move up to the superclass, then.
1249-
</div>
1250-
12511248
<div algorithm>
12521249
The <dfn>[=type=] of a {{CSSUnitValue}}</dfn>
12531250
is the result of [=creating a type=] from its {{CSSUnitValue/unit}} internal slot.
@@ -1388,14 +1385,6 @@ of all the "math" operations.
13881385
Note: These are all instances of the {{CSSMathOperator}} enum.
13891386
</div>
13901387

1391-
<div algorithm="CSSMathValue.type">
1392-
The <dfn attribute for="CSSMathValue, CSSMathSum, CSSMathProduct, CSSMathMin, CSSMathMax, CSSMathNegate, CSSMathInvert">type</dfn> attribute
1393-
of a {{CSSMathValue}} |this| must,
1394-
on reading,
1395-
1396-
Issue: Figure out how we're outputting .type
1397-
</div>
1398-
13991388
<div algorithm="CSSMathSum(...args)">
14001389
The <dfn constructor for="CSSMathSum">CSSMathSum(...|args|)</dfn> constructor must,
14011390
when called,

0 commit comments

Comments
 (0)