Skip to content

Commit 095f658

Browse files
committed
Minor changes
1 parent aea8303 commit 095f658

File tree

2 files changed

+16
-20
lines changed

2 files changed

+16
-20
lines changed

src/components/AppHeader.vue

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div
55
class="z-10 max-w-screen-lg xl:max-w-screen-xl block sm:flex sm:justify-between sm:items-center my-6"
66
>
7-
<!-- Header menu links and small screen humberger menu start -->
7+
<!-- Header menu links and small screen hamburger menu start -->
88
<div class="flex justify-between items-center px-4 sm:px-0">
99
<!-- Header logos start -->
1010
<div>
@@ -33,13 +33,13 @@
3333
/>
3434
<!-- Theme switcher small screen end -->
3535

36-
<!-- Small screen humberger menu start -->
36+
<!-- Small screen hamburger menu start -->
3737
<div class="sm:hidden">
3838
<button
3939
@click="isOpen = !isOpen"
40-
type="buttom"
40+
type="button"
4141
class="focus:outline-none"
42-
aria-label="Humberger Menu"
42+
aria-label="Hamburger Menu"
4343
>
4444
<svg
4545
xmlns="http://www.w3.org/2000/svg"
@@ -60,9 +60,9 @@
6060
</svg>
6161
</button>
6262
</div>
63-
<!-- Small screen humberger menu end -->
63+
<!-- Small screen hamburger menu end -->
6464
</div>
65-
<!-- Header menu links and small screen humberger menu end -->
65+
<!-- Header menu links and small screen hamburger menu end -->
6666

6767
<!-- Header links start -->
6868
<div
@@ -117,15 +117,15 @@
117117
</div>
118118
<!-- Hire me button end -->
119119

120-
<!-- Theme switcher largr screen start -->
120+
<!-- Theme switcher large screen start -->
121121
<theme-switcher
122122
:theme="theme"
123123
@themeChanged="updateTheme"
124124
class="ml-8 bg-primary-light dark:bg-ternary-dark px-3 py-2 shadow-sm rounded-xl cursor-pointer"
125125
/>
126-
<!-- Theme switcher largr screen end -->
126+
<!-- Theme switcher large screen end -->
127127
</div>
128-
<!-- Header right section buttons stendart -->
128+
<!-- Header right section buttons end -->
129129
</div>
130130
<!-- Header end -->
131131

@@ -150,6 +150,10 @@ export default {
150150
ThemeSwitcher,
151151
HireMeModal,
152152
},
153+
mounted() {
154+
this.theme = localStorage.getItem('theme') || 'light';
155+
feather.replace();
156+
},
153157
data() {
154158
return {
155159
isOpen: false,
@@ -164,7 +168,7 @@ export default {
164168
{
165169
id: 2,
166170
value: 'mobile',
167-
name: 'Mobile Applicaiton',
171+
name: 'Mobile Application',
168172
},
169173
{
170174
id: 3,
@@ -179,14 +183,6 @@ export default {
179183
],
180184
};
181185
},
182-
183-
created() {
184-
this.theme = localStorage.getItem('theme') || 'light';
185-
},
186-
mounted() {
187-
feather.replace();
188-
this.theme = localStorage.getItem('theme') || 'light';
189-
},
190186
methods: {
191187
updateTheme(theme) {
192188
this.theme = theme;

src/components/ThemeSwitcher.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<a href="#" @click="toggleTheme" aria-label="Theme Switcher">
2+
<a href="#" @click.prevent="toggleTheme" aria-label="Theme Switcher">
33
<i
44
v-if="theme === 'light'"
55
data-feather="moon"
@@ -26,7 +26,7 @@ export default {
2626
const newTheme = this.theme === 'light' ? 'dark' : 'light';
2727
localStorage.setItem('theme', newTheme);
2828
this.$emit('themeChanged', newTheme);
29-
this.$router.go();
29+
// this.$router.go();
3030
},
3131
},
3232
};

0 commit comments

Comments
 (0)