Skip to content

Commit b5843ab

Browse files
tabatkinstabatkins
committed
[css-values] Fix WPT and other Bikeshed errors
1 parent 770cf68 commit b5843ab

File tree

2 files changed

+45
-39
lines changed

2 files changed

+45
-39
lines changed

‎css-values-3/Overview.bs‎

Lines changed: 41 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ Textual Data Types</h2>
369369
consist of a sequence of characters conforming to the <<ident-token>> grammar. [[!CSS-SYNTAX-3]]
370370
Identifiers cannot be quoted;
371371
otherwise they would be interpreted as strings.
372-
CSS properties accept two classes of <a>identifiers</a>:
372+
CSS properties accept two classes of [=CSS/identifiers=]:
373373
[[#keywords|pre-defined keywords]]
374374
and [[#custom-idents|author-defined identifiers]].
375375

@@ -417,11 +417,9 @@ CSS-wide keywords: ''initial'', ''inherit'' and ''unset''</h4>
417417
the <a href="https://www.w3.org/TR/css-cascade/#defaulting-keywords">CSS Cascading and Inheritance Module</a>.
418418

419419
<wpt>
420-
css/css-values/initial-background-color.html
421420
css/css-multicol/multicol-inherit-002.xht
422421
css/css-multicol/multicol-rule-color-inherit-001.xht
423422
css/css-multicol/multicol-rule-color-inherit-002.xht
424-
css/css-values/unset-value-storage.html
425423
css/CSS2/values/units-008.xht
426424
</wpt>
427425

@@ -434,7 +432,7 @@ Author-defined Identifiers: the <<custom-ident>> type</h3>
434432

435433
Some properties accept arbitrary author-defined identifiers as a component value.
436434
This generic data type is denoted by <dfn id="identifier-value">&lt;custom-ident></dfn>,
437-
and represents any valid CSS <a>identifier</a>
435+
and represents any valid <a>CSS identifier</a>
438436
that would not be misinterpreted as a pre-defined keyword in that property's value definition.
439437
Such identifiers are fully case-sensitive,
440438
even in the ASCII range
@@ -668,6 +666,10 @@ Empty URLs</h4>
668666
Its computed value is ''url("")'',
669667
and it must serialize as such.
670668

669+
<wpt>
670+
css/css-values/urls/empty.html
671+
</wpt>
672+
671673
Note: This matches the behavior of empty urls for embedded resources elsewhere in the web platform,
672674
and avoids excess traffic re-requesting the stylesheet or host document
673675
due to editing mistakes leaving the ''url()'' value empty,
@@ -831,7 +833,7 @@ Numbers with Units: <a>dimension</a> values</h3>
831833
When written literally,
832834
a <a>dimension</a> is a <a>number</a>
833835
immediately followed by a unit identifier,
834-
which is an <a>identifier</a>.
836+
which is an [=CSS/identifier=].
835837
It corresponds to the <<dimension-token>> production
836838
in the <a href="https://www.w3.org/TR/css-syntax/">CSS Syntax Module</a> [[!CSS-SYNTAX-3]].
837839
Like keywords, unit identifiers are <a>ASCII case-insensitive</a>.
@@ -948,7 +950,7 @@ Mixing Percentages and Dimensions</h3>
948950
Note: Specifications should never alternate <<percentage>> in place of a dimension
949951
in a grammar unless they are <a>compatible</a>.
950952

951-
Note: More &lt;<var>type</var>-percentage> productions can be added in the future as needed.
953+
Note: More &lt;<var ignore>type</var>-percentage> productions can be added in the future as needed.
952954
A &lt;number-percentage> will never be added,
953955
as <<number>> and <<percentage>> can't be combined in ''calc()''.
954956

@@ -1827,37 +1829,37 @@ Mathematical Expressions: ''calc()''</h3>
18271829
css/css-values/calc-min-height.html
18281830
css/css-values/calc-nesting.html
18291831
css/css-values/calc-parenthesis-stack.html
1830-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-background-image-gradient-1.html
1831-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-background-linear-gradient-1.html
1832-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-background-position-1.html
1833-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-background-size-1.html
1834-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-border-radius-1.html
1835-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-height-block-1.html
1836-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-height-table-1.html
1837-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-margin-block-1.html
1838-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-max-height-block-1.html
1839-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-max-width-block-1.html
1840-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-max-width-block-intrinsic-1.html
1841-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-min-height-block-1.html
1842-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-min-width-block-1.html
1843-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-min-width-block-intrinsic-1.html
1844-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-absolute-bottom-1.html
1845-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-absolute-left-1.html
1846-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-absolute-right-1.html
1847-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-absolute-top-1.html
1848-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-relative-bottom-1.html
1849-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-relative-left-1.html
1850-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-relative-right-1.html
1851-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-offsets-relative-top-1.html
1852-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-padding-block-1.html
1853-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-text-indent-1.html
1854-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-text-indent-intrinsic-1.html
1855-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-transform-origin-1.html
1856-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-vertical-align-1.html
1857-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-width-block-1.html
1858-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-width-block-intrinsic-1.html
1859-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-width-table-auto-1.html
1860-
css/vendor-imports/mozilla/mozilla-central-reftests/values3/calc-width-table-fixed-1.html
1832+
css/css-values/calc-background-image-gradient-1.html
1833+
css/css-values/calc-background-linear-gradient-1.html
1834+
css/css-values/calc-background-position-1.html
1835+
css/css-values/calc-background-size-1.html
1836+
css/css-values/calc-border-radius-1.html
1837+
css/css-values/calc-height-block-1.html
1838+
css/css-values/calc-height-table-1.html
1839+
css/css-values/calc-margin-block-1.html
1840+
css/css-values/calc-max-height-block-1.html
1841+
css/css-values/calc-max-width-block-1.html
1842+
css/css-values/calc-max-width-block-intrinsic-1.html
1843+
css/css-values/calc-min-height-block-1.html
1844+
css/css-values/calc-min-width-block-1.html
1845+
css/css-values/calc-min-width-block-intrinsic-1.html
1846+
css/css-values/calc-offsets-absolute-bottom-1.html
1847+
css/css-values/calc-offsets-absolute-left-1.html
1848+
css/css-values/calc-offsets-absolute-right-1.html
1849+
css/css-values/calc-offsets-absolute-top-1.html
1850+
css/css-values/calc-offsets-relative-bottom-1.html
1851+
css/css-values/calc-offsets-relative-left-1.html
1852+
css/css-values/calc-offsets-relative-right-1.html
1853+
css/css-values/calc-offsets-relative-top-1.html
1854+
css/css-values/calc-padding-block-1.html
1855+
css/css-values/calc-text-indent-1.html
1856+
css/css-values/calc-text-indent-intrinsic-1.html
1857+
css/css-values/calc-transform-origin-1.html
1858+
css/css-values/calc-vertical-align-1.html
1859+
css/css-values/calc-width-block-1.html
1860+
css/css-values/calc-width-block-intrinsic-1.html
1861+
css/css-values/calc-width-table-auto-1.html
1862+
css/css-values/calc-width-table-fixed-1.html
18611863
css/mediaqueries/mq-calc-001.html
18621864
css/mediaqueries/mq-calc-002.html
18631865
css/mediaqueries/mq-calc-003.html
@@ -2292,7 +2294,7 @@ Changes</h2>
22922294
regardless of base-url shenanigans.
22932295
(See [[#local-urls]].)
22942296
<li>Defined attr() parsing in terms of the Syntax spec, not CSS2.1 grammar.
2295-
(See [[#attr-notation]].)
2297+
22962298
</ul>
22972299

22982300
A <a href="https://drafts.csswg.org/css-values-3/issues-cr-2016">Disposition of Comments</a> is available.
@@ -2307,7 +2309,7 @@ Changes</h2>
23072309
<li>Defined an empty <<url>> resolves to an invalid resource.
23082310
<li>Defined <a>compatible units</a> and <a>canonical units</a> for serialization.
23092311
<li>Defined case-sensitivity of ''url()'' attribute argument to match attribute selectors.
2310-
<li>Added definition of <<ident>> notation to definition of <a>identifiers</a>.
2312+
<li>Added definition of <<ident>> notation to definition of [=CSS/identifiers=].
23112313
<li>Added <<length-percentage>> as a shorthand for <<length>> | <<percentage>>,
23122314
along with equivalent productions for angles, numbers, times, and frequencies.
23132315
<li>Allowed <<percentage>>s inside ''calc()'' to resolve as their own type,

‎css-values-4/Overview.bs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -997,6 +997,10 @@ Empty URLs</h4>
997997
Its computed value is ''url("")'',
998998
and it must serialize as such.
999999

1000+
<wpt>
1001+
css/css-values/urls/empty.html
1002+
</wpt>
1003+
10001004
Note: This matches the behavior of empty urls for embedded resources elsewhere in the web platform,
10011005
and avoids excess traffic re-requesting the stylesheet or host document
10021006
due to editing mistakes leaving the ''url()'' value empty,

0 commit comments

Comments
 (0)