Skip to content

Commit 02d8f91

Browse files
committed
Spinner: Some code and test cleanup
1 parent eebf8c3 commit 02d8f91

File tree

4 files changed

+4
-22
lines changed

4 files changed

+4
-22
lines changed

tests/unit/spinner/spinner.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<script type="text/javascript" src="../../../external/jquery.mousewheel-3.0.2.js"></script>
1010
<script type="text/javascript" src="../../../ui/jquery.ui.core.js"></script>
1111
<script type="text/javascript" src="../../../ui/jquery.ui.widget.js"></script>
12+
<script type="text/javascript" src="../../../ui/jquery.ui.button.js"></script>
1213
<script type="text/javascript" src="../../../ui/jquery.ui.spinner.js"></script>
1314

1415
<link rel="stylesheet" href="../../../external/qunit.css" type="text/css"/>

tests/unit/spinner/spinner_defaults.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,17 @@
33
*/
44

55
var spinner_defaults = {
6-
buttons: 'show',
7-
currency: false,
86
dir: 'ltr',
97
disabled: false,
10-
groupSeparator: '',
118
incremental: true,
129
max: null,
1310
min: null,
1411
mouseWheel: true,
15-
padding: 0,
12+
numberformat: "n",
1613
page: 5,
17-
precision: 0,
18-
radix: 10,
19-
radixPoint: '.',
2014
spinnerClass: null,
2115
step: null,
22-
value: 0,
23-
width: false
16+
value: 0
2417
};
2518

2619
commonWidgetTests('spinner', { defaults: spinner_defaults });

tests/unit/spinner/spinner_options.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -468,15 +468,4 @@ test("value", function() {
468468
equals(el.val(), 1000, "value option changed and set as current value");
469469
});
470470

471-
test("width", function() {
472-
expect(2);
473-
474-
el = $('#spin').spinner({ width: 1000 });
475-
equals(el.width(), 1000, "spinner width initialized");
476-
477-
el.spinner('option', 'width', 500);
478-
equals(el.width(), 500, "spinner width changed");
479-
480-
});
481-
482471
})(jQuery);

ui/jquery.ui.spinner.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,14 @@ $.widget('ui.spinner', {
2727
min: null,
2828
mouseWheel: true,
2929
numberformat: "n",
30-
padding: 0,
3130
page: 5,
3231
spinnerClass: null,
3332
step: null,
3433
value: 0
3534
},
3635

3736
_create: function() {
38-
this.value(this._parse(this.element.val() || this.options.value));
37+
this.value(this.element.val() || this.options.value);
3938
this._draw();
4039
this._mousewheel();
4140
this._aria();

0 commit comments

Comments
 (0)