Skip to content
This repository was archived by the owner on Dec 11, 2021. It is now read-only.

Commit 48104de

Browse files
committed
Comments: Comments are now CSS Compliant, Fixed Typos
Fixes gh-78 Closes gh-78
1 parent 1ab1a15 commit 48104de

File tree

11 files changed

+90
-60
lines changed

11 files changed

+90
-60
lines changed

demos/typography.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h1>Heading 1 &lt;h1&gt;</h1>
2828
<p>Many say exploration is part of our destiny, but it’s actually our duty to future generations and their quest to ensure the survival of the human species.</p>
2929

3030
<h2>Heading 2 &lt;h2&gt;</h2>
31-
<p>It suddenly struck me that that tiny pea, pretty and blue, was the Earth. I put up my thumb and shut one eye, and my thumb blotted out the planet Earth. I didn"t feel like a giant. I felt very, very small.</p>
31+
<p>It suddenly struck me that that tiny pea, pretty and blue, was the Earth. I put up my thumb and shut one eye, and my thumb blotted out the planet Earth. I didn't feel like a giant. I felt very, very small.</p>
3232

3333
<h3>Heading 3 &lt;h3&gt;</h3>
3434
<p>The Earth was small, light blue, and so touchingly alone, our home that must be defended like a holy relic. The Earth was absolutely round. I believe I never knew what the word round meant until I saw Earth from space.</p>
@@ -46,11 +46,11 @@ <h6>Heading 6 &lt;h6&gt;</h6>
4646

4747
<h2>Block-level elements</h2>
4848

49-
<p>Here"s a paragraph &lt;p&gt; filled with some <a href="http://spaceipsum.com/">Space Ipsum</a>. Never in all their history have men been able truly to conceive of the world as one: a single sphere, a globe, having the qualities of a globe, a round earth in which all the directions eventually meet, in which there is no center because every point, or none, is center — an equal earth which all men occupy as equals. The airman"s earth, if free men make it, will be truly round: a globe in practice, not in theory.</p>
49+
<p>Here's a paragraph &lt;p&gt; filled with some <a href="http://spaceipsum.com/">Space Ipsum</a>. Never in all their history have men been able truly to conceive of the world as one: a single sphere, a globe, having the qualities of a globe, a round earth in which all the directions eventually meet, in which there is no center because every point, or none, is center — an equal earth which all men occupy as equals. The airman"s earth, if free men make it, will be truly round: a globe in practice, not in theory.</p>
5050

5151
<p>There can be no thought of finishing for ‘aiming for the stars.’ Both figuratively and literally, it is a task to occupy the generations. And no matter how much progress one makes, there is always the thrill of just beginning.</p>
5252

53-
<div>Here"s a div &lt;div&gt;. A Chinese tale tells of some men sent to harm a young girl who, upon seeing her beauty, become her protectors rather than her violators. That"s how I felt seeing the Earth for the first time. I could not help but love and cherish her
53+
<div>Here's a div &lt;div&gt;. A Chinese tale tells of some men sent to harm a young girl who, upon seeing her beauty, become her protectors rather than her violators. That"s how I felt seeing the Earth for the first time. I could not help but love and cherish her
5454
</div>
5555

5656
<article>
@@ -59,7 +59,7 @@ <h3>This is an article &lt;article&gt; with a paragraph</h3>
5959
<p>End of the article.</p>
6060
</article>
6161

62-
<blockquote>Let"s light this fire one more time, Mike, and witness this great nation at its best. &lt;blockquote&gt; via <a href="http://spaceipsum.com/">Space Ipsum</a></blockquote>
62+
<blockquote>Let's light this fire one more time, Mike, and witness this great nation at its best. &lt;blockquote&gt; via <a href="http://spaceipsum.com/">Space Ipsum</a></blockquote>
6363

6464
<p>We choose to go to the moon in this decade and do the other things, not because they are easy, but because they are hard, because that goal will serve to organize and measure the best of our energies and skills, because that challenge is one that we are willing to accept, one we are unwilling to postpone, and one which we intend to win.</p>
6565

@@ -87,10 +87,10 @@ <h2>Lists &lt;li&gt;</h2>
8787
<li>Unordered list &lt;ul&gt;</li>
8888
<li>List element</li>
8989
<li>Across the sea of space, the stars are other suns.</li>
90-
<li>Science cuts two ways, of course; its products can be used for both good and evil. But there"s no turning back from science. The early warnings about technological dangers also come from science.</li>
90+
<li>Science cuts two ways, of course; its products can be used for both good and evil. But there's no turning back from science. The early warnings about technological dangers also come from science.</li>
9191
</ul>
9292

93-
<p>It suddenly struck me that that tiny pea, pretty and blue, was the Earth. I put up my thumb and shut one eye, and my thumb blotted out the planet Earth. I didn"t feel like a giant. I felt very, very small.</p>
93+
<p>It suddenly struck me that that tiny pea, pretty and blue, was the Earth. I put up my thumb and shut one eye, and my thumb blotted out the planet Earth. I didn't feel like a giant. I felt very, very small.</p>
9494

9595
<ol>
9696
<li>Ordered list &lt;ol&gt;</li>
@@ -122,7 +122,7 @@ <h2>Text-level elements</h2>
122122
<li><a href="#">anchor link</a> &lt;a&gt;</li>
123123
<li>abbreviation: <abbr title="Syntactically Awesome Stylesheets">SASS</abbr> &lt;abbr&gt;</li>
124124
<li>citation: <cite>A Study in Scarlet</cite> &lt;cite&gt;</li>
125-
<li>Here"s the <code>&lt;code&gt;</code> element</li>
125+
<li>Here's the <code>&lt;code&gt;</code> element</li>
126126
<li>deleted text: <del>Episodes I, II, III</del> &lt;del&gt;</li>
127127
<li>definition: The <dfn>definition element</dfn> is the element being defined inline. &lt;dfn&gt;</li>
128128
<li><em>emphasis</em> &lt;em&gt;</li>

scss/_utilities/_clearfix.scss

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
// ==========================================================================
2-
// Clearfix
3-
// ==========================================================================
4-
1+
/*
2+
* ==========================================================================
3+
* Clearfix
4+
* ==========================================================================
5+
*/
56

67
@mixin clearfix() {
78
&:before,

scss/_utilities/_colors.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
// ==========================================================================
2-
// Colors
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Colors
4+
* ==========================================================================
5+
*/

scss/atoms/icons/_icons.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
// ==========================================================================
2-
// Icons
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Icons
4+
* ==========================================================================
5+
*/

scss/atoms/typography/_functions.scss

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
// ==========================================================================
2-
// Typography functions
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Typography functions
4+
* ==========================================================================
5+
*/
46

5-
// em() function
6-
// Convert px to em in a readable fashion.
7-
// Examples:
8-
// 1. font-size: em(14px);
9-
// 2. font-size: em(30px/14px);
7+
/*
8+
* em() function
9+
* Convert px to em in a readable fashion.
10+
* Examples:
11+
* 1. font-size: em(14px);
12+
* 2. font-size: em(30px/14px);
13+
*/
1014
@function em($value, $context: map-get($root-font, font-size)) {
1115
@return ($value / $context * 1em);
1216
}

scss/atoms/typography/_mixins.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
// ==========================================================================
2-
// Typography functions
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Typography functions
4+
* ==========================================================================
5+
*/

scss/atoms/typography/_typography.scss

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
// ==========================================================================
2-
// Typography
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Typography
4+
* ==========================================================================
5+
*/
46

57
@import
68
"variables",
@@ -55,9 +57,11 @@ h6 {
5557
text-transform: uppercase;
5658
}
5759

58-
// ==========================================================================
59-
// Block elements
60-
// ==========================================================================
60+
/*
61+
* ==========================================================================
62+
* Block elements
63+
* ==========================================================================
64+
*/
6165

6266
hr {
6367
border: 0;
@@ -78,9 +82,11 @@ pre {
7882
font: normal 12px/1.4 $monospace;
7983
}
8084

81-
// ==========================================================================
82-
// Lists
83-
// ==========================================================================
85+
/*
86+
* ==========================================================================
87+
* Lists
88+
* ==========================================================================
89+
*/
8490

8591
dt {
8692
font-weight: 600;
@@ -90,9 +96,11 @@ dd {
9096
margin: 0;
9197
}
9298

93-
// ==========================================================================
94-
// Inline elements
95-
// ==========================================================================
99+
/*
100+
* ==========================================================================
101+
* Inline elements
102+
* ==========================================================================
103+
*/
96104

97105
a {
98106
//TODO add colors

scss/atoms/typography/_variables.scss

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1-
// ==========================================================================
2-
// Typography variables
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Typography variables
4+
* ==========================================================================
5+
*/
46

5-
// Change these values when using custom fonts
6-
// For example, normal: 400;
7+
/*
8+
* Change these values when using custom fonts
9+
* For example, normal: 400;
10+
*/
711
$normal: normal;
812
$bold: bold;
913
$root-font: (
@@ -12,7 +16,7 @@ $root-font: (
1216
line-height: 1.5
1317
);
1418

15-
// Typefaces
19+
/* Typefaces */
1620
$monospace: "courier new", monospace;
1721
$serif: Georgia, "Times New Roman", Times, serif;
1822
$sans-serif: "Source Sans Pro", Helvetica, Arial, sans-serif;

scss/lint.scss

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1-
// ==========================================================================
2-
// CSS Chassis
3-
//
4-
// This contains all the chassis scss execpt normalize.css which will not pass our linter
5-
// we use this file to create a distributable for linting style.scss which contains this
6-
// file plus normalize.css
7-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* CSS Chassis
4+
*
5+
* This contains all the chassis scss execpt normalize.css which will not pass our linter
6+
* we use this file to create a distriubable for linting style.scss contains this file plus
7+
* normalize.css
8+
* ==========================================================================
9+
*/
10+
811

912
@import
1013
"_utilities/clearfix",

scss/style.scss

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
// ==========================================================================
2-
// CSS Chassis
3-
// ==========================================================================
4-
// This just adds normalize to the build see lint.scss for explanation.
1+
/*
2+
* ==========================================================================
3+
* CSS Chassis
4+
* ==========================================================================
5+
* This just adds normalize to the build see lint.scss for explanation.
6+
*/
57

68
@import
79
"external/normalize.css/normalize.scss",

scss/views/main.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
// ==========================================================================
2-
// Main
3-
// ==========================================================================
1+
/*
2+
* ==========================================================================
3+
* Main
4+
* ==========================================================================
5+
*/

0 commit comments

Comments
 (0)