Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 524f047

Browse files
committed
switch event triggers to trigger with deprecated prefix
1 parent ca6a2e8 commit 524f047

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

js/jquery.mobile.navigation.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ define( [
685685
}, this);
686686
},
687687

688-
// TODO make private once change has been defined in the widget
688+
// TODO make private once change has been defined in the widget1
689689
transition: function( toPage, fromPage, options ) {
690690
var transition = options.transition,
691691
reverse = options.reverse,
@@ -696,9 +696,11 @@ define( [
696696
// TODO decide if these events should in fact be triggered on the container
697697
if ( fromPage ) {
698698
//trigger before show/hide events
699+
// TODO deprecate nextPage in favor of next
699700
this._triggerWithDeprecated( "beforehide", {nextPage: toPage}, fromPage );
700701
}
701702

703+
// TODO deprecate prevPage in favor of previous
702704
this._triggerWithDeprecated( "beforeshow", {prevPage: fromPage || $( "" )}, toPage );
703705

704706
// TODO maybe put this in a binding to events above *outside* the widget
@@ -714,19 +716,21 @@ define( [
714716
promise = transitionHandler( transition, reverse, toPage, fromPage );
715717

716718
// TODO temporary accomodation of argument deferred
717-
$.when( promise ).done(function() {
719+
promise.done(function() {
718720
deferred.resolve.apply(deferred, arguments);
719721
});
720722

721-
promise.done(function() {
723+
promise.done($.proxy(function() {
722724
//trigger show/hide events
723725
if ( fromPage ) {
724-
fromPage.data( "mobile-page" )._trigger( "hide", null, { nextPage: toPage } );
726+
// TODO deprecate nextPage in favor of next
727+
this._triggerWithDeprecated( "hide", {nextPage: toPage}, fromPage );
725728
}
726729

730+
// TODO deprecate prevPage in favor of previous
727731
//trigger pageshow, define prevPage as either fromPage or empty jQuery obj
728-
toPage.data( "mobile-page" )._trigger( "show", null, { prevPage: fromPage || $( "" ) } );
729-
});
732+
this._triggerWithDeprecated( "show", {prevPage: fromPage || $( "" )}, toPage );
733+
}, this));
730734
}
731735

732736

0 commit comments

Comments
 (0)