Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 62881f3

Browse files
committed
refactor to addClass to avoid array alterations/joins
1 parent 7651fd9 commit 62881f3

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

js/jquery.mobile.forms.select.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
6161
if( !!~this.element[0].className.indexOf( "ui-btn-left" ) ) {
6262
classes = " ui-btn-left";
6363
}
64-
64+
6565
if( !!~this.element[0].className.indexOf( "ui-btn-right" ) ) {
6666
classes = " ui-btn-right";
6767
}
68-
68+
6969
this.select = this.element.wrap( "<div class='ui-select" + classes + "'>" );
7070
this.selectID = this.select.attr( "id" );
7171
this.label = $( "label[for='"+ this.selectID +"']" ).addClass( "ui-select" );
@@ -198,13 +198,15 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
198198
},
199199

200200
setButtonText: function() {
201-
var self = this, selected = this.selected(), cls = [self.select.attr("class")];;
201+
var self = this, selected = this.selected();
202202

203203
this.button.find( ".ui-btn-text" ).html( function() {
204-
204+
205205
if ( !self.isMultiple ) {
206-
cls.push(selected.attr("class"));
207-
return $("<span/>", {"class": cls.join(' ')}).text(selected.text());
206+
return $( document.createElement("span") )
207+
.addClass( self.select.attr("class") )
208+
.addClass( selected.attr("class") )
209+
.text( selected.text() );
208210
}
209211

210212
//TODO: apply the span as above to preserve the css-class of the original select

0 commit comments

Comments
 (0)