Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 95579f0

Browse files
committed
Toolbar: removing popup removes page-header-fixed class
Adds _destroy to toolbar.js and _super() for fixedToolbar Fixes gh-6987 Fixes gh-6939
1 parent 50e7c8b commit 95579f0

File tree

2 files changed

+37
-10
lines changed

2 files changed

+37
-10
lines changed

js/widgets/fixedToolbar.js

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -277,22 +277,29 @@ define( [ "jquery", "../widget", "../core", "../animationComplete", "../navigati
277277
},
278278

279279
_destroy: function() {
280-
var classes,
281-
toolbar = this.element,
282-
header = toolbar.hasClass( "ui-header" ),
280+
var pageClasses, toolbarClasses, header, hasFixedChildren,
281+
toolbar = this.element;
282+
283+
this._super();
284+
if ( toolbar.css( "postion" ) === "fixed" ) {
285+
header = toolbar.hasClass( "ui-header" );
283286
hasFixedChildren = toolbar
284287
.closest( ".ui-page" )
285288
.children( ".ui-header-fixed" )
286289
.length > 0;
290+
toolbar
291+
.closest( ".ui-page" )
292+
.css( "padding-" + ( header ? "top" : "bottom" ), "" );
293+
toolbarClasses = "ui-header-fixed ui-footer-fixed ui-header-fullscreen in out";
294+
toolbarClasses += "ui-footer-fullscreen fade slidedown slideup ui-fixed-hidden";
295+
toolbar.removeClass( toolbarClasses );
296+
pageClasses = "ui-page-footer-fixed ui-page-header-fullscreen ui-page-footer-fullscreen";
297+
if ( !hasFixedChildren ) {
298+
pageClasses += "ui-page-header-fixed";
299+
}
287300

288-
toolbar.closest( ".ui-page" ).css( "padding-" + ( header ? "top" : "bottom" ), "" );
289-
toolbar.removeClass( "ui-header-fixed ui-footer-fixed ui-header-fullscreen ui-footer-fullscreen in out fade slidedown slideup ui-fixed-hidden" );
290-
classes = "ui-page-footer-fixed ui-page-header-fullscreen ui-page-footer-fullscreen";
291-
if ( !hasFixedChildren ) {
292-
classes += "ui-page-header-fixed";
301+
toolbar.closest( ".ui-page" ).removeClass( pageClasses );
293302
}
294-
295-
toolbar.closest( ".ui-page" ).removeClass( classes );
296303
}
297304

298305
});

js/widgets/toolbar.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,26 @@ define( [
130130
"role": "heading",
131131
"aria-level": "1"
132132
});
133+
},
134+
_destroy: function() {
135+
var headerAnchors,currentTheme,
136+
toolbar = this.element;
137+
138+
toolbar.children( "h1, h2, h3, h4, h5, h6" )
139+
.removeClass( "ui-title" );
140+
141+
if ( this.role === "header" ) {
142+
headerAnchors = toolbar.children( "a, button" );
143+
headerAnchors.removeClass( "ui-btn-left ui-btn-right" );
144+
toolbar.find( ".ui-toolbar-back-btn" ).remove();
145+
}
146+
147+
if ( this.options.theme !== undefined ) {
148+
currentTheme = this.options.theme ? this.options.theme : "inherit";
149+
toolbar.removeClass( "ui-bar-" + currentTheme );
150+
}
151+
152+
toolbar.removeClass( "ui-" + this.role );
133153
}
134154
});
135155

0 commit comments

Comments
 (0)