Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 99ed56f

Browse files
committed
move args to opts
1 parent 9b165e9 commit 99ed56f

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

js/jquery.mobile.navigation.js

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ define( [
428428
return path.getFilePath( absoluteUrl );
429429
},
430430

431-
_triggerWithDeprecated: function( name, data ) {
431+
_triggerWithDeprecated: function( name, data, page ) {
432432
var deprecatedEvent = $.Event( "page" + name ),
433433
newEvent = $.Event( this.widgetName + name );
434434

@@ -687,7 +687,13 @@ define( [
687687

688688

689689
//function for transitioning between two existing pages
690-
transition: function( toPage, fromPage, transition, reverse, deferred ) {
690+
transition: function( toPage, fromPage, options ) {
691+
var transition = options.transition,
692+
reverse = options.reverse,
693+
deferred = options.deferred,
694+
transitionHandler,
695+
promise;
696+
691697
if ( fromPage ) {
692698
//trigger before show/hide events
693699
fromPage.data( "mobile-page" )
@@ -706,8 +712,9 @@ define( [
706712
//find the transition handler for the specified transition. If there
707713
//isn't one in our transitionHandlers dictionary, use the default one.
708714
//call the handler immediately to kick-off the transition.
709-
var th = $.mobile.transitionHandlers[ transition || "default" ] || $.mobile.defaultTransitionHandler,
710-
promise = th( transition, reverse, toPage, fromPage );
715+
transitionHandler = $.mobile.transitionHandlers[ transition || "default" ] || $.mobile.defaultTransitionHandler;
716+
717+
promise = transitionHandler( transition, reverse, toPage, fromPage );
711718

712719
// TODO temporary accomodation of argument deferred
713720
$.when( promise ).done(function() {
@@ -1251,7 +1258,11 @@ define( [
12511258

12521259
transitionDeferred = $.Deferred();
12531260

1254-
settings.pageContainer.content( "transition", toPage, fromPage, settings.transition, settings.reverse, transitionDeferred );
1261+
settings.pageContainer.content( "transition", toPage, fromPage, {
1262+
transition: settings.transition,
1263+
reverse: settings.reverse,
1264+
deferred: transitionDeferred
1265+
});
12551266

12561267
transitionDeferred.done(function( name, reverse, $to, $from, alreadyFocused ) {
12571268
removeActiveLinkClass();

0 commit comments

Comments
 (0)