From 13cf04089f865640f487d775b68b36e5cba46e89 Mon Sep 17 00:00:00 2001 From: Collin Reisdorf Date: Thu, 2 Dec 2010 17:50:34 -0500 Subject: [PATCH 1/2] fixed the single list item issue, and also added support for rounding the btn-inner when it's the first or last item (or also the only item) --- js/jquery.mobile.listview.js | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/js/jquery.mobile.listview.js b/js/jquery.mobile.listview.js index 80b0f643cd0..5a57e1cd657 100644 --- a/js/jquery.mobile.listview.js +++ b/js/jquery.mobile.listview.js @@ -24,7 +24,7 @@ $.widget( "mobile.listview", $.mobile.widget, { // create listview markup $list .addClass( "ui-listview" ) - .attr( "role", "listbox" ) + .attr( "role", "listbox" ); if ( o.inset ) { $list.addClass( "ui-listview-inset ui-corner-all ui-shadow" ); @@ -233,13 +233,24 @@ $.widget( "mobile.listview", $.mobile.widget, { itemClass += " ui-li-static ui-btn-up-" + o.theme; } - - if( o.inset ){ + if(li.length === 1) { + if ( o.inset ) { + itemClass += " ui-corner-all"; + + item + .add( item.find( ".ui-btn-inner" ).addClass('ui-corner-all') ) + .find( ".ui-li-link-alt" ) + .addClass( "ui-corner-right" ) + .end() + .find( ".ui-li-thumb" ) + .addClass( "ui-corner-left" ); + } + }else if( o.inset ){ if ( pos === 0 ) { itemClass += " ui-corner-top"; - + item - .add( item.find( ".ui-btn-inner" ) ) + .add( item.find( ".ui-btn-inner" ).addClass('ui-corner-top') ) .find( ".ui-li-link-alt" ) .addClass( "ui-corner-tr" ) .end() @@ -248,12 +259,12 @@ $.widget( "mobile.listview", $.mobile.widget, { if(item.next().next().length){ self._removeCorners( item.next() ); } - + } else if ( pos === li.length - 1 ) { itemClass += " ui-corner-bottom"; - + item - .add( item.find( ".ui-btn-inner" ) ) + .add( item.find( ".ui-btn-inner" ).addClass('ui-corner-bottom') ) .find( ".ui-li-link-alt" ) .addClass( "ui-corner-br" ) .end() From 1f45cefcf07fe7c1e2598507abb53dcac511b1c2 Mon Sep 17 00:00:00 2001 From: Collin Reisdorf Date: Mon, 6 Dec 2010 10:27:34 -0500 Subject: [PATCH 2/2] cleaned up the list styling fix to fix my dumb error (code had been pasted from alpha 2, sorry) --- js/jquery.mobile.listview.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/js/jquery.mobile.listview.js b/js/jquery.mobile.listview.js index 5a57e1cd657..66138931d6e 100644 --- a/js/jquery.mobile.listview.js +++ b/js/jquery.mobile.listview.js @@ -233,10 +233,11 @@ $.widget( "mobile.listview", $.mobile.widget, { itemClass += " ui-li-static ui-btn-up-" + o.theme; } - if(li.length === 1) { - if ( o.inset ) { + + if( o.inset ){ + if(li.length === 1) { itemClass += " ui-corner-all"; - + item .add( item.find( ".ui-btn-inner" ).addClass('ui-corner-all') ) .find( ".ui-li-link-alt" ) @@ -244,9 +245,7 @@ $.widget( "mobile.listview", $.mobile.widget, { .end() .find( ".ui-li-thumb" ) .addClass( "ui-corner-left" ); - } - }else if( o.inset ){ - if ( pos === 0 ) { + }else if ( pos === 0 ) { itemClass += " ui-corner-top"; item