8000 Removed "jquery.mobile" prefix from filenames by gseguin · Pull Request #6465 · jquery-archive/jquery-mobile · GitHub
Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
325 commits
Select commit Hold shift + click to select a range
08f0475
Pagecontainer: create public method to retrieve the activePage
arschmitz Sep 24, 2013
f5a8c67
Swipe: change horizontal threshold back to 30px Fixes #6422 - Idea fo…
arschmitz Sep 24, 2013
3a5da67
'Changed version to: 1.4.0-beta.1'
gseguin Sep 24, 2013
11bbb9a
'Changed version to: 1.4.0pre'
gseguin Sep 24, 2013
45c015b
Nojs: Needs to depend on jquery.mobile.ns.
Sep 25, 2013
67d7e71
Fixed toolbar: Do not apply workarounds unless the toolbar really is …
Sep 25, 2013
330e61c
Fixed toolbar: Apply workarounds from _makeFixed().
Sep 26, 2013
7d7f7a5
Demos: Intro: Show non-deprecated example for filterable.
Sep 26, 2013
a40b350
Demos: Pages: Update link hrefs to reflect new directory structure.
Sep 26, 2013
8f5faaa
Demos: jqm-contents: Typo.
Sep 26, 2013
573359f
Demos: External toolbar: Ajax -> AJAX.
Sep 26, 2013
d3c0196
Demos: Navigation: More copy editing and link-fixing.
Sep 26, 2013
ab8c7fc
Demos: changed Buttons page title to Button markup
jaspermdegroot Sep 26, 2013
514d323
Listview: fixed incorrect border radius property.
jaspermdegroot Sep 26, 2013
e8e193c
Demos: footer should not be positioned absolute on C-grade browsers.
jaspermdegroot Sep 27, 2013
b0b232a
Demos: changed file names. Fixes #6522.
jaspermdegroot Sep 27, 2013
3ab4a04
Demos: Navigation PHP redirect example: Update for 1.4.0.
Sep 27, 2013
51c0fce
Demos: View source: Reposition popup when any collapsible is collapse…
Sep 27, 2013
621c715
Panel: Animate class is added before opening the panel.
jaspermdegroot Sep 27, 2013
c013af5
pagecontainer: load() should be able to deal with a missing options h…
Sep 27, 2013
261c50d
Demos: Use and document $( ":mobile-pagecontainer" ).pagecontainer( "…
Sep 27, 2013
da45dd0
Panel: Reduced selectors.
jaspermdegroot Sep 28, 2013
c350637
Demos: Updated responsive panel CSS example.
jaspermdegroot Sep 28, 2013
cfce8a8
Demos: Updated toolbar themes.
jaspermdegroot Sep 28, 2013
2f5ade1
Demos: Use the method to dynamically disable/enable form widgets. Fix…
jaspermdegroot Sep 29, 2013
91b17ba
Applied changes made in default theme to classic theme.
jaspermdegroot Sep 29, 2013
5be9a21
Moved classic theme from CSS themes folder to the demos.
jaspermdegroot Sep 29, 2013
de5d715
Demos: h2widget: Do not act if you encounter the hash for a popup out…
Sep 30, 2013
7df6eb2
Demos: Popup outside the page: Set theme "a" explicitly, because the …
Sep 30, 2013
a5c76da
Demos: Panel styling demo improvements.
jaspermdegroot Sep 30, 2013
853f39e
Demos: External persistent toolbars for swipe page nav demo. Fixes #6…
jaspermdegroot Sep 30, 2013
5e8fb76
Demos: Page header: Add role="button" to navigation buttons.
Sep 30, 2013
e0e1b8a
Demos: Updated button markup in swipe page nav demo.
jaspermdegroot Sep 30, 2013
ae0d4e1
Demos: Update button markup
jaspermdegroot Sep 30, 2013
1f9f7b4
Demos: Added role="button" to examples on button markup page.
jaspermdegroot Sep 30, 2013
d1ee19a
Demos: Swipe page: Set href for Trivia button upon pageshow to point …
Sep 30, 2013
48fdff1
Links: Do not delegate popupafteropen/popupafterclose handlers to hre…
Sep 30, 2013
82ffc81
Whitespace
jaspermdegroot Sep 30, 2013
cf259a4
Collapsible list item: New demo: Fixes #5539 - Collapsible list items
Sep 24, 2013
bb98ba6
Demos: Collapsible list items: Simplifying examples.
Sep 25, 2013
f0d60ba
Demos: Added collapsible list items demo to the menu
jaspermdegroot Sep 26, 2013
3b966e1
Demos: Collapsible list item: Making whitespace consistent.
Sep 26, 2013
e1805ac
Demos: Collapsible list items: Splitting into two demos: flat and ind…
Sep 27, 2013
2c6bda5
Demos: Collapsible list items: Adding example of list item that does …
Sep 30, 2013
0045d09
Demos: Navigation: Reflect collapsible list item demo split.
Sep 30, 2013
63bf3e7
Demos: Collapsible list item: Indentation changes.
Sep 30, 2013
85e5750
Popup: Make sure the screen stretches over the entire document if CSS…
Oct 1, 2013
87645bb
demos: updated navbar elements to menu items 1,2 and 3
agcolom Oct 1, 2013
25df38d
Fixed toolbar workarounds: Left an empty _create() lying around.
Oct 1, 2013
fc63746
Demos: Selectmenu: Fixing 404. Fixes #6542.
Oct 1, 2013
56aa247
Selectmenu: Fixed missing check icon in multiple menu. Fixes #6526.
jaspermdegroot Oct 1, 2013
f678b0d
Popup: Toggle true/false for the aria-expanded attribute of all links…
Oct 1, 2013
c95f9ee
Links: Do not attach two event handlers for each popup link to the do…
Oct 1, 2013
efb6e63
Demos: Controlgroup: Eliminating data-role="button".
Oct 1, 2013
d4247fa
Demos: Replacing data-role="button" in the FAQ.
Oct 1, 2013
4ac202a
Demos: Toolbar: Back button text and theme are set on the toolbar pro…
Oct 2, 2013
32f04d3
Selectmenu: Updated disabled class to ui-state-disabled.
jaspermdegroot Oct 2, 2013
3b83627
Pagecontainer: add back forward and go methods to allow navigation ba…
arschmitz Oct 1, 2013
e7d4c5d
Controlgroup: use keepnativeselector to filter children to be enhance…
arschmitz Oct 2, 2013
9d2933d
Demos: Add buttonMarkup-related classes by hand.
Oct 2, 2013
8cb215e
Pagecontainer: Do not start a load message timeout if one is already …
Sep 30, 2013
1d456e5
Pagecontainer: Separate emission of non-deprecated "pagecontainerload…
Sep 30, 2013
db19668
Demos: Navigation PHP redirect: Add two-second delay to both the redi…
Sep 30, 2013
bf339aa
Pagecontainer: send samePage param to pagehide event so page widget c…
arschmitz Oct 2, 2013
e3a4b90
Pagecontainer: Linting make sure to use tripple equal
arschmitz Oct 3, 2013
656c778
Flipswitch: rename _create to refresh and refresh on change event Fix…
arschmitz Oct 3, 2013
1d7c247
Toolbar: Modified deprecation comment.
jaspermdegroot Oct 2, 2013
e212a7c
Demos: Added custom style for h3 headings.
jaspermdegroot Oct 2, 2013
1783a3e
Demos: Small change in default demo page.
jaspermdegroot Oct 2, 2013
6e4bd70
Demos: Updated all toolbar demo pages.
jaspermdegroot Oct 3, 2013
87bdf27
Demos: added note to FAQ pages that they are not updated.
jaspermdegroot Oct 3, 2013
c7f7be4
Checkboxradio: Use the state instead of the icon class in the selector.
jaspermdegroot Oct 2, 2013
b6533c2
Selectmenu: Multiple custom menu items should get the checkbox state …
jaspermdegroot Oct 2, 2013
0810aee
Theme: Simplified selectors for checkbox and radio style.
jaspermdegroot Oct 2, 2013
9a47c39
Icons: Simplified selector for checkbox icon.
jaspermdegroot Oct 2, 2013
343af0e
Checkboxradio: Don't add icon classes because we don't use them anymore.
jaspermdegroot Oct 2, 2013
70c861b
Tests: Updated form integration test.
jaspermdegroot Oct 3, 2013
537a3f2
Demos: Small changes in persistent toolbar demo.
jaspermdegroot Oct 3, 2013
8000
7b6d666
Demos: Typo in theme pages.
jaspermdegroot Oct 3, 2013
5ef86a3
Demos: Removed ui-shadow class from header buttons.
jaspermdegroot Oct 3, 2013
89371aa
Typo in comment. Fixes #6530. Thanks @mauk81 !
jaspermdegroot Oct 3, 2013
992cd37
Demos: Fixed linkbar demo view source. Renamed folder. Fixes #6553.
jaspermdegroot Oct 3, 2013
170679c
Unit tests: Checkboxradio: Ensure widget correctly handles dynamic in…
Oct 4, 2013
8496046
Controlgroup: Refresh after chaining up, because checkboxradio needs …
Oct 4, 2013
8bd059b
Checkboxradio: Widget behaves correctly inside controlgroups as they …
Oct 4, 2013
154af21
Toolbar: Do not add back button if it is already added, and do not us…
Oct 4, 2013
2f9c9a6
Demos: Consistency in heading levels, ensures that the headings are s…
jaspermdegroot Oct 4, 2013
f4c25f1
Demos: Fixed broken links on intro page.
jaspermdegroot Oct 4, 2013
de85aec
Demos: Various corrections and small changes in one pass.
jaspermdegroot Oct 4, 2013
0246f7c
Demos: Updated popup demos.
jaspermdegroot Oct 4, 2013
154892a
Demos: Fixed broken links on form page.
jaspermdegroot Oct 4, 2013
f98fc5c
Demos: Cleaned up popup page.
jaspermdegroot Oct 4, 2013
e3961d6
Demos: Updated icon page.
jaspermdegroot Oct 4, 2013
7d5de8a
Demos: Changes in external toolbar demos.
jaspermdegroot Oct 4, 2013
430c7bc
Demos: Added dynamic toolbar demo.
jaspermdegroot Oct 4, 2013
13122c1
Demos: Fixed a typo in a class name.
jaspermdegroot Oct 4, 2013
ea971b5
Demos: Added full width slider demo. Fixes #5847
jaspermdegroot Oct 4, 2013
e5b5462
Demos: Removed ui-btn-active ui-state-persist classes from external t…
jaspermdegroot Oct 4, 2013
7998fba
Demos: Added some info to field container demo page.
jaspermdegroot Oct 6, 2013
31ce82e
Demos: Added demo how-to set nav buttons in true persistent toolbar t…
jaspermdegroot Oct 6, 2013
810a9f8
Docs: Remove data-role="fieldcontain" Closes #6569
soberstadt Oct 5, 2013
c365939
Demos: Removed double space in link to framework CSS.
jaspermdegroot Oct 6, 2013
af38a0b
Demos: Added link to CSS file in classic theme demo.
jaspermdegroot Oct 6, 2013
7177111
Demos: External toolbars: Typo.
Oct 7, 2013
f799667
Flipswitch: Trigger "change" and handle form reset. Fixes #6572 - Fli…
Oct 7, 2013
44066de
Navigation: Remove active class from button during click when it is a…
Oct 7, 2013
dfcf757
Integration tests: Navigation: Adding test for click handlers.
Oct 7, 2013
3d8a213
Panel: Use classes instead of :jqmData in selectors to take enhanced …
jaspermdegroot Oct 8, 2013
b174232
Demos: Updated popup tooltip example.
jaspermdegroot Oct 8, 2013
78cc052
Integration tests: Form reset: Make sure reset works with flipswitch.
Oct 8, 2013
013db26
Flipswitch: Add option corners.
Oct 8, 2013
e4ec0ff
Demos: Flipswitch: Demo option corners.
Oct 8, 2013
4a9d588
Demos: Fixed broken links on grids demo page.
jaspermdegroot Oct 8, 2013
4921f49
Demos: Improvements to theme demo pages.
jaspermdegroot Oct 8, 2013
8b284a1
Columntoggle table: Simplifying code, removing superfluous data attri…
Oct 9, 2013
08b262c
Unit tests: Table: We no longer set role="button" on the "Columns..."…
Oct 9, 2013
35b7164
Columntoggle table: fieldcontain is not used.
Oct 9, 2013
f36c32c
Stop panel from being removed if attribute data-id persistent exists
PangbornIdentity Sep 19, 2013
a26fbf0
Panel: do not remove wrapper if it is used by another panel Fixes - #…
PangbornIdentity Sep 30, 2013
18b43dd
Columntoggle table: Enable instantiation based on pre-rendered markup.
Oct 9, 2013
d7972ca
Toolbar: make sure position relative is only set on page for non-fixe…
arschmitz Oct 10, 2013
79c262d
enhanceWithin: Make sure to respect keepNative when calling buttonMar…
arschmitz Oct 10, 2013
58ed61b
Demos: Text correction.
jaspermdegroot Oct 14, 2013
2b3d663
fixed broken link from single page template to multi-page template in…
rocco Oct 11, 2013
0601e47
Page.dialog: remove close function and isClosable prop use regular ba…
arschmitz Oct 15, 2013
43b530e
defaults: Removing touchOverflowEnabled, which was deprecated in 1.1.
Oct 15, 2013
b84206f
Demos: Dialog-styled pages: Started update.
Oct 16, 2013
b30239b
Demos: Remove trailing whitespace and make sure there are no two sequ…
Oct 16, 2013
f310f09
Revert "Demos: Remove trailing whitespace and make sure there are no …
Oct 16, 2013
848eac0
Theme: New active colors for default theme. Thanks @toddparker !
jaspermdegroot Oct 16, 2013
9c34fc0
Theme: Changed swatch A font color and text shadow color.
jaspermdegroot Oct 16, 2013
475b056
Theme: A bit darker background color for bar A to improve contrast.
jaspermdegroot Oct 16, 2013
3dc6860
Demos: First pass on new navmenu.
jaspermdegroot Oct 7, 2013
a116cf5
Demos: Switching to overlay panel for the navmenu.
jaspermdegroot Oct 7, 2013
eab410f
Demos: Removing role="button" from anchors.
Oct 8, 2013
7303bf0
Demos: Replaced data-role="button" in toolbar demo popup.
jaspermdegroot Oct 9, 2013
3329e3a
Demos: Replaced data-role="button" in Backbone demo.
jaspermdegroot Oct 9, 2013
75b94dd
Demos: Nav menu active style tweak.
jaspermdegroot Oct 12, 2013
8ac7468
Demos: Removed script for old global search input.
jaspermdegroot Oct 12, 2013
c90c9e5
Demos: Clean up page linking demo.
jaspermdegroot Oct 12, 2013
75d3359
Indentation
jaspermdegroot Oct 12, 2013
762f9f1
Demos: Content custom style tweaks.
jaspermdegroot Oct 12, 2013
8e7def6
Demos: Prevent transitions on global navmenu panel at wide screens.
jaspermdegroot Oct 13, 2013
fedabf6
Demos: Global navmenu changes.
jaspermdegroot Oct 14, 2013
268221c
Demos: Header style changes.
jaspermdegroot Oct 14, 2013
91dbaa9
Demos: Global navmenu style.
jaspermdegroot Oct 14, 2013
5b35f01
Demos: Added style for pages without global navmenu.
jaspermdegroot Oct 14, 2013
fb15911
Demos: Reorganized form demo pages.
jaspermdegroot Oct 16, 2013
1cce2f9
Demos: No quicklinks if only one section on page.
jaspermdegroot Oct 16, 2013
0fb7029
Demos: Removed fieldcontain hide label examples because it has been d…
jaspermdegroot Oct 16, 2013
d1d0ba8
Demos: Removed slider grid demos. They were only for testing.
jaspermdegroot Oct 16, 2013
031aee0
Demos: Removed textinput fieldcontain hide label example because it h…
jaspermdegroot Oct 16, 2013
d517d8c
Demos: Custom active style for global navmenu.
jaspermdegroot Oct 16, 2013
a3daf4f
Demos: Improved panel demo pages.
jaspermdegroot Oct 16, 2013
a970f88
Demos: Fixed broken links.
jaspermdegroot Oct 16, 2013
e93d37e
Demos: fix demos search panel and page Fixes #6619 - Demos: fix searc…
arschmitz Oct 17, 2013
b035ac7
Demos: clean up jqm-demos.js reduce event bindings and simplify where…
arschmitz Oct 17, 2013
59912bd
Demos: Prevent keywords being added multiple times; Coding standards …
jaspermdegroot Oct 17, 2013
1c16c71
Demos: Custom style for search.
jaspermdegroot Oct 17, 2013
d453239
Demos: Input button: Add corners and shadow to pre-rendered input but…
8000 Oct 17, 2013
1dc3a55
Clear button: Whitespace fix.
Oct 17, 2013
1f7f72d
Textinput: Split long initSelector into multiple rows.
Oct 17, 2013
483767d
Textinput: Set disabled option based on disabled property /before/ co…
Oct 17, 2013
464efa1
Panel: Override overflow-x hidden for active page when panel is open.…
jaspermdegroot Oct 18, 2013
155f7fb
Tests: Fixed a typo.
jaspermdegroot Oct 18, 2013
7110dd1
Textinput: fix initselector which breaks jquery 1.8.3
arschmitz Oct 18, 2013
ed57827
Demos: No icons in search list, while not removing them from every li…
jaspermdegroot Oct 18, 2013
1be210f
Demos: Focus on the input when search panel opens.
jaspermdegroot Oct 18, 2013
97dcd68
Demos: No focus style for search panel input.
jaspermdegroot Oct 18, 2013
674ff48
Demos: Line breaks before and after code blocks.
jaspermdegroot Oct 19, 2013
fc6f221
Demos: Removed styles that are now part of the default theme from cus…
jaspermdegroot Oct 19, 2013
07bda50
Demos: Popup tooltip example missing title attr, broken transition, c…
jaspermdegroot Oct 19, 2013
c121f00
Demos: Cleanup markup.
jaspermdegroot Oct 19, 2013
92426d6
Demos: Added textinput and checkboxradio enhanced examples.
jaspermdegroot Oct 19, 2013
d7150b4
enhanceWithin: store element sets for widgets before any enhancment t…
arschmitz Oct 20, 2013
18a9692
enhanceWithin: make surre the elements passed to buttonMarkup are fil…
arschmitz Oct 20, 2013
78d8663
Button: _setOptions: Fixed the bugs of _setOptions - The button widge…
hyunsook Oct 18, 2013
8114b8f
Button: _setOptions: Fixed the bugs of _setOptions - The button widge…
hyunsook Oct 18, 2013
be0aa22
Button: _setOptions: Fixed the bugs of _setOptions - The button widge…
hyunsook Oct 18, 2013
5a9121c
Button: Simplify application of icon-related classes.
Oct 20, 2013
2d83bc8
Helpers: Call $.mobile.page.prototype.keepNativeSelector() only once …
Oct 20, 2013
c64bb89
Button: Separate icon classes with a space during creation.
Oct 21, 2013
45dfc96
enhanceWithin: Save a few more function calls by not attempting to en…
Oct 21, 2013
d2a8773
Demos: Replaced deprecated code in panel swipe open demo.
jaspermdegroot Oct 21, 2013
5cc4019
Demos: Updated panel demo title.
jaspermdegroot Oct 21, 2013
4dbdc38
Rangeslider: Instantiate sliders if they are not there by the time th…
Oct 21, 2013
8446855
Collapsible: Theme is also inherited.
Oct 21, 2013
8ac119c
js/jquery.mobile.js: Change order of requirements to accommodate enha…
Oct 21, 2013
b35a3bf
Gruntfile.js: Re-order modules specified via the --modules option suc…
Oct 21, 2013
d84c151
Panel: Adjusted CSS for dismiss modal. Fixes #6640.
jaspermdegroot Oct 21, 2013
ce9698d
Panel: Removed superfluous selector.
jaspermdegroot Oct 21, 2013
0fbc906
Panel: Cleanup comments.
jaspermdegroot Oct 21, 2013
c894d73
Panel: Removed overflow setting for active page now the page can't be…
jaspermdegroot Oct 21, 2013
844296a
Demos: Typo fix.
jaspermdegroot Oct 21, 2013
5954584
Revert "js/jquery.mobile.js: Change order of requirements to accommod…
Oct 22, 2013
8921a80
js/jquery.mobile.js: change order of widgets.
allsteady Oct 18, 2013
4d767f9
Table: Clear after floating column toggle button. Fixes #6639.
jaspermdegroot Oct 22, 2013
22fc554
Listview hideDividers: Fix capitalization: hideDividers is correct, n…
Oct 22, 2013
00f12c6
Demos: Removing trailing whitespace and double blank lines
Oct 22, 2013
57e5dfd
Library: Removing trailing whitespace and double blank lines.
Oct 22, 2013
b7eb0f7
Panel: No transition for Windows Phone in case of fixed toolbars. Fix…
jaspermdegroot Oct 23, 2013
ee0af83
Grid: Margin for buttons inside ui-grid-solo. Fixes #6643.
jaspermdegroot Oct 23, 2013
d08c06d
Fixed toolbar: tapToggle - hide external fixed footers. Fixes #6604.
jaspermdegroot Oct 23, 2013
2edd496
Selectmenu: It need not define option "disabled", because that option…
Oct 23, 2013
ff0c523
Page: Mark option contentTheme as deprecated.
Oct 24, 2013
45d5116
Demos: Replace data-role="content" with role="main" class="ui-content".
Oct 24, 2013
27c58db
Updated the Gruntfile to fix demos PHP includes.
jaspermdegroot Oct 24, 2013
7844fde
'Changed version to: 1.4.0-rc.1'
gseguin Oct 24, 2013
f6c7b54
'Changed version to: 1.4.0pre'
gseguin Oct 24, 2013
1ee41c0
Build: Long overdue cleanup
gseguin Oct 24, 2013
0e65179
Commit
gseguin Oct 25, 2013
1649985
Build: Use strict versions for devDependencies
gseguin Oct 31, 2013
a546c66
Revert "Commit"
gseguin Oct 31, 2013
b1223df
Changelog: inital commit of new changelog script
arschmitz Aug 21, 2013
9900994
Changelog: add first label to issue
arschmitz Aug 22, 2013
97bee31
Build: cleanup change log for code quality
arschmitz Oct 29, 2013
3c482a2
Demos: Buttons inside grid solo should be wrapped in element with ui-…
jaspermdegroot Nov 1, 2013
40adf30
Demos: Listview: Fixed a typo arrow-r for the default icon value.
hyunsook Nov 1, 2013
961fc64
Modules: use relative path for anonymous modules
gseguin Nov 13, 2013
62583d4
Modules: use relative path for anonymous modules
gseguin Nov 13, 2013
8c2c01e
Modules: use relative path for anonymous modules
gseguin Nov 13, 2013
4362c5c
Modules: Removed "require" dependency and added noop function for use…
gseguin Nov 13, 2013
1fdbbb6
Modules: use relative path for anonymous modules
gseguin Nov 13, 2013
43eab1a
Lint: Fix comma at the end of a hash, not caught by the linter. Fixes…
Nov 14, 2013
34c47cf
Demos: Flipswitch: Add examples using custom indentation and custom w…
Nov 14, 2013
a81e132
Gruntfile.js: Distribute jquery.mobile.icons.css, and add replacement…
Nov 15, 2013
488c4d2
Merged master branch
gseguin Aug 6, 2013
05e1db3
Fixed tests after removal of "jquery.mobile" prefix in filenames
gseguin Sep 12, 2013
7d5dbfc
Tests: Use .then after calling reloadModule
gseguin Sep 13, 2013
c2df61a
Tests: Another attempt at making TravisCI happy. split jquery.mobile.…
gseguin Sep 13, 2013
af80947
Revert "Tests: Another attempt at making TravisCI happy. split jquery…
gseguin Sep 13, 2013
b2dbf5e
Revert "Tests: Another attempt at making TravisCI happy. Removed susp…
gseguin Sep 14, 2013
7ab81f9
Linting: Removed trailing space
gseguin Nov 15, 2013
2aa3183
Removed jquery.mobile prefix
gseguin Nov 15, 2013
1a098b6
Tests: Fixed init test suite
gseguin Nov 15, 2013
5ddb36d
Tests: Removed prefix jquery.mobile
gseguin Nov 15, 2013
69c79ae
Added no-prefix branch to Travis build
gseguin Nov 18, 2013
413b106
Commented all tests but one to see what makes Travis barf
gseguin Nov 18, 2013
cdcbb94
Tests: use the shared object to test if the page is defined
gseguin Nov 18, 2013
45b322f
Tests: Limit tests to the init suite to locate the issue
gseguin Nov 18, 2013
6d42eda
Tests: Be verbose
gseguin Nov 18, 2013
38bd588
Tests: Added 1 more init test
gseguin Nov 18, 2013
aac2e1c
Tests: Added 1 more init test
gseguin Nov 18, 2013
5175f95
Tests: Added 1 more init test
gseguin Nov 18, 2013
87fffb0
Tests: Added 1 more init test
gseguin Nov 18, 2013
1ec8752
Tests: Added 1 more init test
gseguin Nov 18, 2013
2a4a6cc
Tests: Added 2 more init tests
gseguin Nov 18, 2013
48e782b
Tests: Added 2 more init tests
gseguin Nov 18, 2013
f5c2f2d
Tests: Re-added last init test
gseguin Nov 18, 2013
3c20b84
Re-enabled all tests
gseguin Nov 18, 2013
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93D4
Next Next commit
Pagecontainer: create public method to retrieve the activePage
  • Loading branch information
arschmitz authored and gseguin committed Nov 15, 2013
commit 08f04755eae875d3f8994e2a38de776c5381df3d
4 changes: 2 additions & 2 deletions js/widgets/pagecontainer.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ define( [
},

// TODO active page should be managed by the container (ie, it should be a property)
_getActiveContent: function() {
getActivePage: function() {
return this.activePage;
},

Expand Down Expand Up @@ -223,7 +223,7 @@ define( [
},

_handleDialog: function( changePageOptions, data ) {
var to, active, activeContent = this._getActiveContent();
var to, active, activeContent = this.getActivePage();

// If current active page is not a dialog skip the dialog and continue
// in the same direction
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/content/content_core.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
test( "continues backward when the active content isn't a dialog", function() {
expect( 2 );

proto._getActiveContent = function() {
proto.getActivePage = function() {
return $( "<div>" );
};

Expand All @@ -105,7 +105,7 @@
test( "continues forward when the active content isn't a dialog", function() {
expect( 2 );

proto._getActiveContent = function() {
proto.getActivePage = function() {
return $( "<div>" );
};

Expand All @@ -119,7 +119,7 @@
test( "extends changePageOptions when current content is a dialog", function() {
var result, opts = {};

proto._getActiveContent = function() {
proto.getActivePage = function() {
return $( "<div>", {"class": "ui-dialog"} );
};

Expand Down