Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Commit 1375954

Browse files
committed
Code review
1 parent 6c4c0e9 commit 1375954

File tree

6 files changed

+1975
-2011
lines changed

6 files changed

+1975
-2011
lines changed

.editorconfig

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# This file is for unifying the coding style for different editors and IDEs
2+
# editorconfig.org
3+
4+
root = true
5+
6+
[*]
7+
indent_style = tab
8+
end_of_line = lf
9+
charset = utf-8
10+
trim_trailing_whitespace = true
11+
insert_final_newline = true
12+
13+
[*.yml]
14+
indent_style = space
15+
indent_size = 2

.github/workflows/node.js.yml

+8-11
Original file line numberDiff line numberDiff line change
@@ -8,32 +8,29 @@ on:
88
permissions:
99
contents: read # to fetch code (actions/checkout)
1010

11+
env:
12+
NODE_VERSION: 20.x
13+
1114
jobs:
1215
build-and-test:
1316
runs-on: ubuntu-latest
14-
name: ${{ matrix.NPM_SCRIPT }} - ${{ matrix.NAME }} (${{ matrix.NODE_VERSION }})
15-
strategy:
16-
fail-fast: false
17-
matrix:
18-
NAME: ["Node"]
19-
NODE_VERSION: [20.x]
20-
NPM_SCRIPT: ["test"]
17+
name: test
2118
steps:
2219
- name: Checkout
2320
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
2421

25-
- name: Use Node.js ${{ matrix.NODE_VERSION }}
22+
- name: Use Node.js ${{ env.NODE_VERSION }}
2623
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
2724
with:
28-
node-version: ${{ matrix.NODE_VERSION }}
25+
node-version: ${{ env.NODE_VERSION }}
2926

3027
- name: Cache
3128
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 # v4.0.1
3229
with:
3330
path: ~/.npm
34-
key: ${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
31+
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
3532
restore-keys: |
36-
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-npm-lock-
33+
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
3734
3835
- name: Install dependencies
3936
run: npm install

lib/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"type": "commonjs"
2+
"type": "commonjs"
33
}

0 commit comments

Comments
 (0)