Skip to content
This repository was archived by the owner on Jan 16, 2020. It is now read-only.

Commit 837d45e

Browse files
committed
Remove explicit handling for invalid manifest path. This should never happen now that we search for manifest files before trying to read them.
1 parent e96c0ff commit 837d45e

2 files changed

Lines changed: 1 addition & 11 deletions

File tree

lib/service.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ extend( Repo.prototype, {
3939
return fn( error );
4040
}
4141

42-
if ( !manifest ) {
43-
logger.log( "Error getting manifest", repo.id, version, file );
44-
return fn( null, null );
45-
}
46-
4742
try {
4843
manifest = JSON.parse( manifest );
4944
} catch( error ) {

lib/service/github.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,7 @@ extend( GithubRepo.prototype, {
110110

111111
_getManifest: function( version, file, fn ) {
112112
version = version || "master";
113-
exec( "git show " + version + ":" + file, { cwd: this.path }, function( error, stdout, stderr ) {
114-
// this will also result in an error being passed, so we check stderr first
115-
if ( stderr && stderr.substring( 0, 11 ) === "fatal: Path" ) {
116-
return fn( null, null );
117-
}
118-
113+
exec( "git show " + version + ":" + file, { cwd: this.path }, function( error, stdout ) {
119114
if ( error ) {
120115
return fn( error );
121116
}

0 commit comments

Comments
 (0)