Skip to content
This repository was archived by the owner on Jan 16, 2020. It is now read-only.

Commit 8ac6082

Browse files
committed
Update all dependencies; add .jshintrc.
1 parent 8396170 commit 8ac6082

8 files changed

Lines changed: 32 additions & 15 deletions

File tree

.jshintrc

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"curly": true,
3+
"eqnull": true,
4+
"eqeqeq": true,
5+
"expr": true,
6+
"noarg": true,
7+
"node": true,
8+
"onevar": true,
9+
"trailing": true,
10+
"undef": true,
11+
"unused": true,
12+
"strict": false
13+
}

grunt.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ grunt.initConfig({
1010
src: [ "lib/**", "scripts/**" ]
1111
},
1212

13+
jshint: {
14+
grunt: { options: grunt.file.readJSON( ".jshintrc" ) },
15+
src: { options: grunt.file.readJSON( ".jshintrc" ) }
16+
},
17+
1318
test: {
1419
files: [ "test/**/*.js" ]
1520
},

lib/hook.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
var semver = require( "semver" ),
2-
Step = require( "step" ),
1+
var Step = require( "step" ),
32
pluginsDb = require( "./pluginsdb" ),
43
retry = require( "./retrydb" ),
54
logger = require( "./logger" );
@@ -136,7 +135,7 @@ function processRelease( repo, tag, file, manifest, fn ) {
136135
},
137136

138137
// track the new release
139-
function( error, owner ) {
138+
function( /*error, owner*/ ) {
140139
pluginsDb.addRelease( repo.id, tag, file, manifest, this );
141140
},
142141

lib/retrydb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ module.exports = {
8888
var Step = require( "step" );
8989

9090
Step(
91-
function( error ) {
91+
function() {
9292
connect( this );
9393
},
9494

lib/service.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ function isObject( obj ) {
2020
return ({}).toString.call( obj ) === "[object Object]";
2121
}
2222

23-
function isUrl( str ) {
23+
function isUrl( /*str*/ ) {
2424
// TODO: URL validation
2525
return true;
2626
}
@@ -342,7 +342,8 @@ extend( Repo.prototype, {
342342

343343
// validate manifests
344344
function( error, files, manifests ) {
345-
var mappedManifests = {};
345+
var i, l,
346+
mappedManifests = {};
346347

347348
if ( error ) {
348349
return fn( error );
@@ -355,7 +356,7 @@ extend( Repo.prototype, {
355356
return fn( null, null );
356357
}
357358

358-
for ( var i = 0, l = manifests.length; i < l; i++ ) {
359+
for ( i = 0, l = manifests.length; i < l; i++ ) {
359360
if ( repo.validateManifest( manifests[ i ], tag,
360361
suites[ repo.id ], files[ i ] ).length ) {
361362
return fn( null, null );

lib/service/github.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
var fs = require( "fs" ),
22
querystring = require( "querystring" ),
33
exec = require( "child_process" ).exec,
4-
semver = require( "semver" ),
54
Step = require( "step" ),
65
mkdirp = require( "mkdirp" ),
76
service = require( "../service" );
@@ -97,7 +96,7 @@ extend( GithubRepo.prototype, {
9796
},
9897

9998
getManifestFiles: function( tag, fn ) {
100-
exec( "git ls-tree " + tag + " --name-only", { cwd: this.path }, function( error, stdout, stderr ) {
99+
exec( "git ls-tree " + tag + " --name-only", { cwd: this.path }, function( error, stdout ) {
101100
if ( error ) {
102101
return fn( error );
103102
}

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
"url": "git://github.com/jquery/plugins.jquery.com.git"
1010
},
1111
"dependencies": {
12-
"mkdirp": "0.3.3",
13-
"semver": "1.0.14",
12+
"mkdirp": "0.3.4",
13+
"semver": "1.1.2",
1414
"sqlite3": "2.1.5",
1515
"step": "0.0.5",
16-
"rimraf": "2.0.2",
16+
"rimraf": "2.1.1",
1717
"wordpress": "0.1.3",
18-
"grunt": "0.3.12",
19-
"grunt-wordpress": "1.0.2",
18+
"grunt": "0.3.17",
19+
"grunt-wordpress": "1.0.5",
2020
"logger": "git://github.com/jquery/node-logger.git"
2121
}
2222
}

scripts/wordpress-update.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ actions.addRelease = function( data, fn ) {
168168
wordpress.newPost( pageDetails, this.parallel() );
169169
},
170170

171-
function( error, versions, latest ) {
171+
function( error /*, versions, latest*/ ) {
172172
if ( error ) {
173173
return fn( error );
174174
}

0 commit comments

Comments
 (0)