Skip to content

Commit 507478b

Browse files
committed
✨ jQuery v1.3.3-sec
1 parent ac014c5 commit 507478b

File tree

4 files changed

+140
-116
lines changed

4 files changed

+140
-116
lines changed

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ In a perfect world, at least every MAJOR EOL jQuery release line would have a se
3535
| jQuery version | jQuery-sec version | Branch | PR | Release | CVEs Patched |
3636
| -------------- | ------------------ | ----------- | -------------- | ------- | ------------------------------------------------------------------------------------------------------------------------------------ |
3737
| `1.2.6` | `1.2.7-sec` | [1.2.7-sec] | [PR][1.2.7-pr] | | [CVE-2011-4969] \| [CVE-2012-6708] \| <del>CVE-2015-9251</del>* \| [CVE-2019-11358] \| [CVE-2020-7656] \| [CVE-2020-11022] \| [CVE-2020-11023] |
38-
| `1.3.2` | `1.3.3-sec` | | | | [CVE-2011-4969] \| [CVE-2012-6708] \| [CVE-2015-9251] \| [CVE-2019-11358] \| [CVE-2020-7656] \| [CVE-2020-11022] \| [CVE-2020-11023] |
38+
| `1.3.2` | `1.3.3-sec` | [1.3.3-sec] | [PR][1.3.3-pr] | | [CVE-2011-4969] \| [CVE-2012-6708] \| <del>CVE-2015-9251</del>* \| [CVE-2019-11358] \| [CVE-2020-7656] \| [CVE-2020-11022] \| [CVE-2020-11023] |
3939
| `1.4.4` | `1.4.5-sec` | | | | [CVE-2011-4969] \| [CVE-2012-6708] \| [CVE-2015-9251] \| [CVE-2019-11358] \| [CVE-2020-7656] \| [CVE-2020-11022] \| [CVE-2020-11023] |
4040
| `1.5.2` | `1.5.3-sec` | | | | [CVE-2011-4969] \| [CVE-2012-6708] \| [CVE-2015-9251] \| [CVE-2019-11358] \| [CVE-2020-7656] \| [CVE-2020-11022] \| [CVE-2020-11023] |
4141
| `1.6.4` | `1.6.5-sec` | [1.6.5-sec] | [PR][1.6.5-pr] | | [CVE-2012-6708] \| [CVE-2015-9251] \| [CVE-2019-11358] \| [CVE-2020-7656] \| [CVE-2020-11022] \| [CVE-2020-11023] |
@@ -45,7 +45,7 @@ In a perfect world, at least every MAJOR EOL jQuery release line would have a se
4545
| `2.2.4` | `2.2.5-sec` | | | | [CVE-2015-9251] \| [CVE-2019-11358] \| [CVE-2020-11022] \| [CVE-2020-11023] \| [CVE-2020-23064] |
4646

4747
> [!IMPORTANT]
48-
> *CVE-2015-9251 is not reproducible in `1.2.6`
48+
> *CVE-2015-9251 is not reproducible in `1.2.6` and `1.3.2`
4949
5050
> [!NOTE]
5151
> The 3.x release line is currently supported by jQuery, so we have no need to provide patched versions of 3.x at this time. jQuery 3.5 introduced a breaking change, but it was necessary to fix CVE-2020-11022 and CVE-2020-11023. However, since these vulnerabilities are present in virtually all versions of jQuery, there would be no value in providing a patched version of 3.4 as it would need to include that breaking change anyway.
@@ -60,8 +60,13 @@ Ultimately, our hope is that these patched versions can be approved and accepted
6060

6161
[1.2.7-sec]: https://github.com/ctcpip/jquery-security-patches/tree/1.2.7-sec
6262
[1.2.7-pr]: https://github.com/ctcpip/jquery-security-patches/pull/2
63+
64+
[1.3.3-sec]: https://github.com/ctcpip/jquery-security-patches/tree/1.3.3-sec
65+
[1.3.3-pr]: https://github.com/ctcpip/jquery-security-patches/pull/3
66+
6367
[1.6.5-sec]: https://github.com/ctcpip/jquery-security-patches/tree/1.6.5-sec
6468
[1.6.5-pr]: https://github.com/ctcpip/jquery-security-patches/pull/1
69+
6570
[CVE-2011-4969]: https://github.com/advisories/GHSA-579v-mp3v-rrw5
6671
[CVE-2012-6708]: https://github.com/advisories/GHSA-2pqj-h3vj-pqgw
6772
[CVE-2015-9251]: https://github.com/advisories/GHSA-rmxg-73gg-4p98

security/README.md

Lines changed: 40 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,52 @@
1-
# Testing
1+
# Testing (and building) jQuery
22

33
> [!IMPORTANT]
4-
> In order to keep the version PRs clean, you will need to use different branches depending on whether you want to run the jQuery tests or the A/B CVE tests. For the A/B CVE tests, you need to checkout the `main` branch. For the jQuery tests, you need to checkout the branch of the version you are interested in, e.g. `1.6.5-sec`.
4+
> In order to keep the version PRs clean, you will need to use different branches depending on whether you want to run the jQuery tests, build jQuery, or run the A/B CVE tests. For the A/B CVE tests, you need to checkout the `main` branch. For the jQuery tests or to build jQuery, you need to checkout the branch of the version you are interested in, e.g. `1.6.5-sec`.
55
6-
## jQuery tests
6+
## Testing
77

8-
### How to run jQuery tests
8+
### jQuery tests
99

10-
Includes instructions only for how to run the tests on MacOS. (PRs welcome for instructions for other platforms!)
10+
#### How to run jQuery tests
1111

12-
#### 1.2.6 / 1.2.7-sec
12+
##### 1.2.6 / 1.2.7-sec
1313

14+
- Checkout the `1.2.6` or `1.2.7-sec` branch
1415
- Run `make test` from the root folder of the repo
1516
- Open `/tests/index.html` in your browser
1617

17-
#### 1.6.4 / 1.6.5-sec
18+
##### 1.3.2 / 1.3.3-sec
1819

19-
##### Prerequisites
20+
<!-- - Checkout the `1.3.2` or `1.3.3-sec` branch
21+
- Run `make test` from the root folder of the repo
22+
- Open `/tests/index.html` in your browser -->
23+
24+
##### 1.6.4 / 1.6.5-sec
25+
26+
###### Prerequisites
2027

2128
- Install php 5.6
22-
- We recommend using [homebrew-php](https://github.com/shivammathur/homebrew-php)
29+
- For Macs, We recommend using [homebrew-php](https://github.com/shivammathur/homebrew-php)
2330

24-
##### Running the tests
31+
###### Running the tests
2532

26-
- Checkout the branch of the version you are interested in, e.g. `1.6.5-sec`
33+
- Checkout the `1.6.4` or `1.6.5-sec` branch
2734
- Run php server from the root folder of the repo: `php -S 127.0.0.1:8000`
2835
- Open `127.0.0.1:8000/tests/index.html` in your browser
2936

30-
## A/B end-to-end acceptance tests
37+
### A/B end-to-end acceptance tests
3138

3239
Tests run on every push in CI via [GitHub workflow](https://github.com/ctcpip/jquery-security-patches/actions/workflows/security-test.yml)
3340

3441
You can run the A/B tests locally in CI mode or manually in the browser
3542

36-
### How to run A/B end-to-end acceptance tests in CI mode
43+
#### How to run A/B end-to-end acceptance tests in CI mode
3744

3845
- Checkout the `main` branch
3946
- Run `nom test` in `/security/test`
4047
- Rejoice!
4148

42-
### How to run A/B end-to-end acceptance tests manually
49+
#### How to run A/B end-to-end acceptance tests manually
4350

4451
- Checkout the `main` branch
4552
- Run `nom run serve` in `/security/test`
@@ -49,3 +56,22 @@ You can run the A/B tests locally in CI mode or manually in the browser
4956
- Check the `Patched` checkbox to load the patched version of the jQuery version you selected
5057
- An attempt is made to trigger all CVEs automatically, but you can attempt to trigger them again by clicking their respective buttons
5158
- Rejoice!
59+
60+
## Building
61+
62+
<!-- markdownlint-disable-next-line MD024 -->
63+
### 1.2.6 / 1.2.7-sec
64+
65+
- Checkout the `1.2.6` or `1.2.7-sec` branch
66+
- Run `make jquery` from the root folder of the repo
67+
- this will output `./dist/jquery.js`
68+
69+
<!-- markdownlint-disable-next-line MD024 -->
70+
### 1.3.2 / 1.3.3-sec
71+
72+
- Checkout the `1.3.2` or `1.3.3-sec` branch
73+
- Run `make jquery` from the root folder of the repo
74+
- this will output `./dist/jquery.js`
75+
76+
<!-- markdownlint-disable-next-line MD024 -->
77+
### 1.6.4 / 1.6.5-sec

0 commit comments

Comments
 (0)