Skip to content

Commit 831625c

Browse files
committed
jquery offset: reducing more the code size.
1 parent ac324c9 commit 831625c

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/offset.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ jQuery.fn.extend({
140140

141141
// Create scrollLeft and scrollTop methods
142142
jQuery.each( ['Left', 'Top'], function(i, name) {
143-
jQuery.fn[ 'scroll' + name ] = function(val) {
143+
var method = 'scroll' + name;
144+
145+
jQuery.fn[ method ] = function(val) {
144146
if (!this[0]) return;
145147

146148
return val != undefined ?
@@ -149,17 +151,17 @@ jQuery.each( ['Left', 'Top'], function(i, name) {
149151
this.each(function() {
150152
this == window || this == document ?
151153
window.scrollTo(
152-
name == 'Left' ? val : jQuery(window)[ 'scrollLeft' ](),
153-
name == 'Top' ? val : jQuery(window)[ 'scrollTop' ]()
154+
!i ? val : jQuery(window).scrollLeft(),
155+
i ? val : jQuery(window).scrollTop()
154156
) :
155-
this[ 'scroll' + name ] = val;
157+
this[ method ] = val;
156158
}) :
157159

158160
// Return the scroll offset
159161
this[0] == window || this[0] == document ?
160-
self[ (name == 'Left' ? 'pageXOffset' : 'pageYOffset') ] ||
161-
jQuery.boxModel && document.documentElement[ 'scroll' + name ] ||
162-
document.body[ 'scroll' + name ] :
163-
this[0][ 'scroll' + name ];
162+
self[ i ? 'pageYOffset' : 'pageXOffset' ] ||
163+
jQuery.boxModel && document.documentElement[ method ] ||
164+
document.body[ method ] :
165+
this[0][ method ];
164166
};
165167
});

0 commit comments

Comments
 (0)