Skip to content

Added jsDelivr #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added jsDelivr #8

wants to merge 1 commit into from

Conversation

jimaek
Copy link
Contributor

@jimaek jimaek commented Jul 10, 2014

Added jsDelivr as asked in jquery-validation/jquery-validation#1207

@jzaefferer
Copy link
Collaborator

I just checked this out (sorry for the delay). Since your PR, I released 1.13.1 and I can quickly update the new section for that version. But how is jsdelivr.com updated? It still lists 1.13.0 as the current version, about one month after the release of 1.13.1.

@jimaek
Copy link
Contributor Author

jimaek commented Nov 12, 2014

I can enable auto-updates, I just have 1 question. Is this folder required to be hosted by us? https://github.com/jzaefferer/jquery-validation/tree/1.13.1/src/localization

Will anything break if its not present?

@jzaefferer
Copy link
Collaborator

I think its fine to only host the files in dist/. The others are not requred, nothing will break.

jimaek added a commit to jsdelivr/jsdelivr that referenced this pull request Dec 9, 2014
@jimaek
Copy link
Contributor Author

jimaek commented Dec 9, 2014

Added jsdelivr/jsdelivr#2674

@jzaefferer
Copy link
Collaborator

Looks like the bot rejected its own PR. Not sure what to make of that.

@jimaek
Copy link
Contributor Author

jimaek commented Dec 9, 2014

haha we have 2 bots. One updates and the other checks and leaves comments for the mods. I merged it and it should be online now

@jzaefferer
Copy link
Collaborator

Nice. Could you update this PR to the latest version and files, too? Thanks.

@jimaek
Copy link
Contributor Author

jimaek commented Dec 9, 2014

Done, check it out

@jzaefferer jzaefferer closed this in 1610c42 Dec 9, 2014
@jzaefferer
Copy link
Collaborator

Thanks. Just went live.

@jimaek
Copy link
Contributor Author

jimaek commented Dec 9, 2014

awesome

@jimaek jimaek deleted the patch-1 branch December 9, 2014 16:52
@jzaefferer
Copy link
Collaborator

Looks like the automatic update also works, just got notified about the 1.14.0 PR and merge. Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants