jQuery.isNumber: Clarify purpose and behavior #864
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042 An updated note is already in the 3.0 docs. |
|
Yes, but it the update in v3.0.0-docs is independent of gh-862 (which this PR addresses). |
|
It's not completely independent. The notes overlap. |
|
Keep in mind that limiting it to strings and numbers is a change of behavior for 3.0. |
|
Yeah, sorry I missed that. Fixed. |
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0"?> | |||
| <entry type="method" name="jQuery.isNumeric" return="Boolean"> | |||
| <title>jQuery.isNumeric()</title> | |||
| <desc>Determines whether its argument is a number.</desc> | |||
| <desc>Determines whether its argument represents a Javascript number.</desc> | |||
There was a problem hiding this comment.
JavaScript is misspelled here.
|
@AurelioDeRosa done. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-862
Ref jquery/jquery#2781
I held off in case the method gets removed, but that's no reason not to have good documentation while it's still around.