Skip to content

Incorrect styling of <code> in events #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scottgonzalez opened this issue Aug 3, 2012 · 4 comments
Closed

Incorrect styling of <code> in events #28

scottgonzalez opened this issue Aug 3, 2012 · 4 comments

Comments

@scottgonzalez
Copy link
Member

For some reason <code> elements in events have different styling than other <code> elements.
@kborchers
Copy link
Member

The reason is the selector specifies p code so it's only styling <code> elements inside <p> elements. I can easily change that but wondering if anyone knows why that was done and why the style above that line was commented out.

@scottgonzalez
Copy link
Member Author

I have no idea why we would want to handle styles differently for code elements based on location. I was looking through the JS for the base theme yesterday and I had a bunch of questions about that code too. I'll talk to @rdworth about this and figure out what's going on.

@scottgonzalez scottgonzalez mentioned this issue Aug 6, 2012
Closed
@scottgonzalez
Copy link
Member Author

This is fixed.

@scottgonzalez scottgonzalez reopened this Aug 7, 2012
@scottgonzalez
Copy link
Member Author

Now it's really fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottgonzalez @kborchers