Skip to content

Commit 284e9fc

Browse files
committed
Package: Use package-1-13* files for UI 1.13 & newer
Closes gh-582
1 parent e0c624c commit 284e9fc

File tree

6 files changed

+31
-15
lines changed

6 files changed

+31
-15
lines changed

Gruntfile.js

+10
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,11 @@ function buildPackages( folder, callback ) {
413413

414414
// (a) Build jquery-ui-[VERSION].zip;
415415
function( callback ) {
416+
if ( semver.gte( jqueryUi.pkg.version, "1.13.0-a" ) ) {
417+
packagerZip( "./lib/package-1-13", "jquery-ui-" + jqueryUi.pkg.version,
418+
new ThemeGallery( jqueryUi )[ 0 ].vars, folder, jqueryUi, callback );
419+
return;
420+
}
416421
if ( semver.gte( jqueryUi.pkg.version, "1.12.0-a" ) ) {
417422
packagerZip( "./lib/package-1-12", "jquery-ui-" + jqueryUi.pkg.version,
418423
new ThemeGallery( jqueryUi )[ 0 ].vars, folder, jqueryUi, callback );
@@ -438,6 +443,11 @@ function buildPackages( folder, callback ) {
438443

439444
// (b) Build themes package jquery-ui-themes-[VERSION].zip;
440445
function( callback ) {
446+
if ( semver.gte( jqueryUi.pkg.version, "1.13.0-a" ) ) {
447+
packagerZip( "./lib/package-1-13-themes", "jquery-ui-themes-" + jqueryUi.pkg.version,
448+
null, folder, jqueryUi, callback );
449+
return;
450+
}
441451
if ( semver.gte( jqueryUi.pkg.version, "1.12.0-a" ) ) {
442452
packagerZip( "./lib/package-1-12-themes", "jquery-ui-themes-" + jqueryUi.pkg.version,
443453
null, folder, jqueryUi, callback );

download.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,11 @@ Frontend.prototype = {
151151

152152
// The new way to generate a package.
153153
} else {
154-
Package = require( "./lib/package-1-12" );
154+
if ( semver.gte( jqueryUi.pkg.version, "1.13.0-a" ) ) {
155+
Package = require( "./lib/package-1-13" );
156+
} else {
157+
Package = require( "./lib/package-1-12" );
158+
}
155159
packager = new Packager( jqueryUi.files().cache, Package, {
156160
components: components,
157161
themeVars: themeVars,

lib/package-1-13-themes.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var async = require( "async" );
44
var extend = require( "util" )._extend;
55
var banner = require( "./banner" );
66
var sqwish = require( "sqwish" );
7-
var Package1_12 = require( "./package-1-12" );
7+
var Package1_13 = require( "./package-1-13" );
88
var path = require( "path" );
99
var ThemeGallery = require( "./themeroller-themegallery" );
1010

@@ -20,19 +20,19 @@ function Package( files, runtime ) {
2020
if ( !runtime.themeVars ) {
2121
runtime.themeVars = this.themeGallery[ 0 ].vars;
2222
}
23-
Package1_12.apply( this, arguments );
23+
Package1_13.apply( this, arguments );
2424
}
2525

2626
extend( Package.prototype, {
27-
"AUTHORS.txt": Package1_12.prototype[ "AUTHORS.txt" ],
28-
"LICENSE.txt": Package1_12.prototype[ "LICENSE.txt" ],
29-
"images": Package1_12.prototype.images,
30-
"jquery-ui.css": Package1_12.prototype[ "jquery-ui.css" ],
31-
"jquery-ui.structure.css": Package1_12.prototype[ "jquery-ui.structure.css" ],
32-
"jquery-ui.theme.css": Package1_12.prototype[ "jquery-ui.theme.css" ],
33-
"jquery-ui.min.css": Package1_12.prototype[ "jquery-ui.min.css" ],
34-
"jquery-ui.structure.min.css": Package1_12.prototype[ "jquery-ui.structure.min.css" ],
35-
"jquery-ui.theme.min.css": Package1_12.prototype[ "jquery-ui.theme.min.css" ],
27+
"AUTHORS.txt": Package1_13.prototype[ "AUTHORS.txt" ],
28+
"LICENSE.txt": Package1_13.prototype[ "LICENSE.txt" ],
29+
"images": Package1_13.prototype.images,
30+
"jquery-ui.css": Package1_13.prototype[ "jquery-ui.css" ],
31+
"jquery-ui.structure.css": Package1_13.prototype[ "jquery-ui.structure.css" ],
32+
"jquery-ui.theme.css": Package1_13.prototype[ "jquery-ui.theme.css" ],
33+
"jquery-ui.min.css": Package1_13.prototype[ "jquery-ui.min.css" ],
34+
"jquery-ui.structure.min.css": Package1_13.prototype[ "jquery-ui.structure.min.css" ],
35+
"jquery-ui.theme.min.css": Package1_13.prototype[ "jquery-ui.theme.min.css" ],
3636

3737
"themes": function( callback ) {
3838
var files = {};

lib/package-1-13.js

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ var indexTemplate, jsBundleIntro, jsBundleOutro,
1313
ThemeRoller = require( "jquery-ui-themeroller" ),
1414
UglifyJS = require( "uglify-js" );
1515

16+
// We're using the same template as 1.12 for now.
1617
indexTemplate = handlebars.compile( fs.readFileSync( __dirname + "/../template/zip/index-1-12.html", "utf8" ) );
1718
Q.longStackSupport = true;
1819

test/package-1-12.0.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,8 @@ tests = {
196196
JqueryUi.all().filter( function( jqueryUi ) {
197197

198198
// Filter supported releases only
199-
return semver.gte( jqueryUi.pkg.version, "1.12.0-a" );
199+
return semver.gte( jqueryUi.pkg.version, "1.12.0-a" ) &&
200+
semver.lt( jqueryUi.pkg.version, "1.13.0-a" );
200201
} ).forEach( function( jqueryUi ) {
201202
function deepTestBuild( obj, tests ) {
202203
var allComponents = jqueryUi.components().map( function( component ) {

test/package-1-13.0.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
var commonFiles, COMMON_FILES_TESTCASES, defaultTheme, newPackage, someWidgets1, someWidgets2, tests, themeFiles, THEME_FILES_TESTCASES,
44
async = require( "async" ),
55
JqueryUi = require( "../lib/jquery-ui" ),
6-
Package = require( "../lib/package-1-12" ),
6+
Package = require( "../lib/package-1-13" ),
77
Packager = require( "node-packager" ),
88
semver = require( "semver" ),
99
themeGallery = require( "../lib/themeroller-themegallery" )();
@@ -196,7 +196,7 @@ tests = {
196196
JqueryUi.all().filter( function( jqueryUi ) {
197197

198198
// Filter supported releases only
199-
return semver.gte( jqueryUi.pkg.version, "1.12.0-a" );
199+
return semver.gte( jqueryUi.pkg.version, "1.13.0-a" );
200200
} ).forEach( function( jqueryUi ) {
201201
function deepTestBuild( obj, tests ) {
202202
var allComponents = jqueryUi.components().map( function( component ) {

0 commit comments

Comments
 (0)