Skip to content

Commit a89634c

Browse files
committed
Update builder unit test according to 1.10.0. Fixes #59
Changes: - Skip checking for external libs jquery.bgiframe-2.1.2.js, jquery.cookie.js, and jquery.metadata.js; - Adds check for animated-overlay.gif image;
1 parent 3813b8a commit a89634c

File tree

3 files changed

+571
-7
lines changed

3 files changed

+571
-7
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
"winston": "0.6.2"
2020
},
2121
"devDependencies": {
22-
"nodeunit": "~0.7.4"
22+
"nodeunit": "~0.7.4",
23+
"semver": "1.1.0"
2324
},
2425
"main": "frontend.js",
2526
"engine": {

test/builder.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var Builder = require( "../lib/builder" ),
22
Release = require( "../lib/release" ),
3+
semver = require( "semver" ),
34
ThemeRoller = require( "../lib/themeroller" ),
45
someWidgets1 = "widget core position autocomplete button menu progressbar spinner tabs".split( " " ),
56
someWidgets2 = "widget core mouse position draggable resizable button datepicker dialog slider tooltip".split( " " ),
@@ -59,16 +60,14 @@ var commonFiles = [
5960
"development-bundle/external/globalize.culture.de-DE.js",
6061
"development-bundle/external/globalize.culture.ja-JP.js",
6162
"development-bundle/external/globalize.js",
62-
"development-bundle/external/jquery.bgiframe-2.1.2.js",
63-
"development-bundle/external/jquery.cookie.js",
64-
"development-bundle/external/jquery.metadata.js",
6563
"development-bundle/external/jquery.mousewheel.js",
6664
"development-bundle/external/jshint.js",
6765
"development-bundle/external/qunit.css",
6866
"development-bundle/themes/base/jquery.ui.all.css",
6967
"development-bundle/themes/base/jquery.ui.base.css",
7068
"development-bundle/themes/base/jquery.ui.theme.css",
7169
"development-bundle/themes/base/jquery-ui.css",
70+
"development-bundle/themes/base/images/animated-overlay.gif",
7271
"development-bundle/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png",
7372
"development-bundle/themes/base/images/ui-bg_flat_75_ffffff_40x100.png",
7473
"development-bundle/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png",
@@ -84,6 +83,7 @@ var commonFiles = [
8483
"development-bundle/themes/base/images/ui-icons_cd0a0a_256x240.png",
8584
"development-bundle/themes/base/minified/jquery.ui.theme.min.css",
8685
"development-bundle/themes/base/minified/jquery-ui.min.css",
86+
"development-bundle/themes/base/minified/images/animated-overlay.gif",
8787
"development-bundle/themes/base/minified/images/ui-bg_flat_0_aaaaaa_40x100.png",
8888
"development-bundle/themes/base/minified/images/ui-bg_flat_75_ffffff_40x100.png",
8989
"development-bundle/themes/base/minified/images/ui-bg_glass_55_fbf9ee_1x400.png",
@@ -518,7 +518,10 @@ tests = {
518518
module.exports = {};
519519

520520
// Build tests for each jqueryUi release
521-
Release.all().forEach(function( release ) {
521+
Release.all().filter(function( release ) {
522+
// Filter supported releases only
523+
return semver.gte( release.pkg.version, "1.10.0" );
524+
}).forEach(function( release ) {
522525
function deepTestBuild( obj, tests ) {
523526
Object.keys( tests ).forEach(function( i ) {
524527
if ( typeof tests[ i ] === "object" ) {
@@ -551,6 +554,6 @@ Release.all().forEach(function( release ) {
551554
}
552555
});
553556
}
554-
module.exports[ release.pkg.version] = {};
555-
deepTestBuild( module.exports[ release.pkg.version], tests );
557+
module.exports[ release.pkg.version ] = {};
558+
deepTestBuild( module.exports[ release.pkg.version ], tests );
556559
});

0 commit comments

Comments
 (0)