From 77b260092f4c5c1e36714ced9dd587d66b8df348 Mon Sep 17 00:00:00 2001 From: Adam Ulvi Date: Tue, 12 Jul 2016 18:00:31 -0700 Subject: [PATCH 1/3] Checking to see if a prop exists before getting it --- download.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/download.js b/download.js index 4c499eae..31ebb545 100644 --- a/download.js +++ b/download.js @@ -159,7 +159,7 @@ Frontend.prototype = { // Log statistics downloadLogger.info( JSON.stringify({ - build_size: packager.stats.toZip.size, + build_size: packager.stats.toZip.hasOwnProperty("size") ? packager.stats.toZip : 'unknown', build_time: packager.stats.build.time + packager.stats.toZip.time, components: components, version: jqueryUi.pkg.version From 1a300d6b1c218884841065687662a673f7dbfd8f Mon Sep 17 00:00:00 2001 From: Adam Ulvi Date: Tue, 12 Jul 2016 18:45:06 -0700 Subject: [PATCH 2/3] Updated the property check --- download.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/download.js b/download.js index 31ebb545..bb6c1666 100644 --- a/download.js +++ b/download.js @@ -157,9 +157,11 @@ Frontend.prototype = { return callback( error ); } // Log statistics + var toZip = packager.stats.toZip; + downloadLogger.info( JSON.stringify({ - build_size: packager.stats.toZip.hasOwnProperty("size") ? packager.stats.toZip : 'unknown', + build_size: toZip && toZip.hasOwnProperty("size") ? toZip.size : 'unknown', build_time: packager.stats.build.time + packager.stats.toZip.time, components: components, version: jqueryUi.pkg.version From e2b469f7d8b5c57cdf2330c9cb2ec14ba2f296da Mon Sep 17 00:00:00 2001 From: Adam Ulvi Date: Tue, 12 Jul 2016 19:12:54 -0700 Subject: [PATCH 3/3] More checking --- download.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/download.js b/download.js index bb6c1666..8d821b30 100644 --- a/download.js +++ b/download.js @@ -162,7 +162,7 @@ Frontend.prototype = { downloadLogger.info( JSON.stringify({ build_size: toZip && toZip.hasOwnProperty("size") ? toZip.size : 'unknown', - build_time: packager.stats.build.time + packager.stats.toZip.time, + build_time: packager.stats.build.time + (toZip && toZip.hasOwnProperty("time") ? toZip.time : 0), components: components, version: jqueryUi.pkg.version })