Skip to content

Re-enable no-unused-expressions rule #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markelog opened this issue Jul 8, 2016 · 2 comments
Closed

Re-enable no-unused-expressions rule #7

markelog opened this issue Jul 8, 2016 · 2 comments

Comments

@markelog
Copy link
Member

markelog commented Jul 8, 2016

It was disabled because of the cases like this -
https://github.com/jquery/jquery/blob/93f706200c6101df137469ba2e0d965e93508991/src/css/showHide.js#L21

But it seems like it is an issue with our code and with eslint too - eslint/eslint#6636

@platinumazure
Copy link
Contributor

I've left a comment on the ESLint issue. I don't think the logic should change (and I would consider the "violations" to be actual code style issues, in my opinion), but I think the error message could be improved.

In the meanwhile, would it help for someone to submit a PR to jQuery and other projects fixing those issues? (One could just turn the rule on locally and replace the commas with semicolons, basically, and then commit the fixes without enabling the rule.)

@markelog
Copy link
Member Author

would it help for someone to submit a PR to jQuery and other projects fixing those issues?

I already did that, no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants