Skip to content

Commit 50f1add

Browse files
committed
fixup! CSS: Warn and fill jQuery.cssNumber and .css(name, Number)
1 parent ee8f83f commit 50f1add

File tree

2 files changed

+5
-20
lines changed

2 files changed

+5
-20
lines changed

src/css.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,12 @@ if ( jQueryVersionSince( "3.4.0" ) && typeof Proxy !== "undefined" ) {
8383
} );
8484
}
8585

86+
// Create a dummy jQuery.cssNumber if missing. It won't be used by jQuery but
87+
// it will prevent code adding new keys to it unconditionally from crashing.
8688
if ( !jQuery.cssNumber ) {
8789
jQuery.cssNumber = {};
8890
}
8991

90-
// jQuery 3.x uses jQuery.cssNumber internally so we can't warn on access there.
91-
if ( jQueryVersionSince( "4.0.0" ) ) {
92-
migrateWarnProp( jQuery, "cssNumber", jQuery.cssNumber,
93-
"jQuery.cssNumber is deprecated" );
94-
}
95-
9692
function isAutoPx( prop ) {
9793

9894
// The first test is used to ensure that:

test/css.js

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -117,19 +117,8 @@ QUnit.test( "jQuery.css with numbers", function( assert ) {
117117

118118
} );
119119

120-
QUnit[ jQueryVersionSince( "4.0.0" ) ? "test" : "skip" ]( "jQuery.cssNumber",
121-
function( assert ) {
122-
assert.expect( 3 );
123-
124-
expectWarning( assert, "Setting cssNumber value", 1, function() {
125-
jQuery.cssNumber.blart = true;
126-
} );
127-
128-
129-
expectWarning( assert, "Getting cssNumber value", 1, function() {
130-
assert.ok( jQuery.cssNumber.blart, "blart was set" );
131-
} );
132-
133-
delete jQuery.cssNumber.blart;
120+
QUnit.test( "jQuery.cssNumber", function( assert ) {
121+
assert.expect( 1 );
134122

123+
assert.ok( jQuery.cssNumber, "jQuery.cssNumber exists" );
135124
} );

0 commit comments

Comments
 (0)