Effects: restore and warn on arity of jQuery.easing functions

markelog · markelog · commit b6b0ea47e326 · 2016-01-31T17:46:53.000+03:00
Uses Function#bind, so it has obvious downside, but it seems acceptable for migrate plugin Fixes #111
diff --git a/src/effects.js b/src/effects.js
@@ -0,0 +1,18 @@
+var old = jQuery.Tween.prototype.run;
+
+jQuery.Tween.prototype.run = function( percent ) {
+	if ( jQuery.easing[ this.easing ].length > 1 ) {
+		migrateWarn(
+			"easing function " +
+			"\"jQuery.easing." + this.easing.toString() +
+			"\" should use only first argument"
+		);
+	}
+
+	jQuery.easing[ this.easing ] = jQuery.easing[ this.easing ].bind(
+		jQuery.easing,
+		percent, this.options.duration * percent, 0, 1, this.options.duration
+	);
+
+	old.apply( this, arguments );
+}
diff --git a/test/effects.js b/test/effects.js
@@ -0,0 +1,20 @@
+module( "effects" );
+
+QUnit.test( "jQuery.easing", function( assert ) {
+    assert.expect( 5 );
+
+    jQuery.easing.test = function( p, n, firstNum, diff ) {
+    	assert.notEqual( p, undefined );
+    	assert.notEqual( n, undefined );
+    	assert.notEqual( firstNum, undefined );
+    	assert.notEqual( diff, undefined );
+    };
+
+    var div = jQuery( "<div>test</div>" );
+
+    div.appendTo( "#qunit-fixture" );
+
+    expectWarning( "easing", function() {
+    	div.animate({ width: 20 }, 10, "test" );
+    });
+});
diff --git a/test/index.html b/test/index.html
@@ -42,6 +42,7 @@
 	<script src="event.js"></script>
 	<script src="traversing.js"></script>
 	<script src="deferred.js"></script>
+	<script src="effects.js"></script>
 </head>
 <body>
 	<div id="qunit"></div>
