squash! Fixes per code review

Author: dmethvin

test/attributes.js

@@ -42,8 +42,8 @@ QUnit.test( ".removeAttr( boolean attribute )", function( assert ) {
 
 } );
 
-QUnit.test( "", function( assert ) {
-	assert.expect( 13 );
+QUnit.test( ".toggleClass( boolean )", function( assert ) {
+	assert.expect( 14 );
 
 	var e = jQuery( "<div />" ).appendTo( "#qunit-fixture" );
 
@@ -52,22 +52,29 @@ QUnit.test( "", function( assert ) {
 		assert.equal( e[ 0 ].className, "", "Assert class is empty (data was empty)" );
 	} );
 
-	expectNoWarning( "toggleClass not full className", function() {
+	expectNoWarning( ".toggleClass( string ) not full className", function() {
 		e.attr( "class", "" );
 		e.toggleClass( "classy" );
 		assert.equal( e.attr( "class" ), "classy", "class was toggle-set" );
 		e.toggleClass( "classy", false );
 		assert.equal( e.attr( "class" ), "", "class was toggle-removed" );
 	} );
 
-	expectWarning( "toggleClass full-className manipulations", function() {
+	expectWarning( ".toggleClass() save and clear", 1, function() {
 		e.addClass( "testD testE" );
 		assert.ok( e.is( ".testD.testE" ), "Assert class present" );
 		e.toggleClass();
 		assert.ok( !e.is( ".testD.testE" ), "Assert class not present" );
-		assert.equal( jQuery.data( e[ 0 ], "__className__" ), "testD testE", "Data was stored" );
+
+		// N.B.: Store should have "testD testE" now, next test will assert that
+	} );
+
+	expectWarning( ".toggleClass() restore", 1, function() {
 		e.toggleClass();
 		assert.ok( e.is( ".testD.testE" ), "Assert class present (restored from data)" );
+	} );
+
+	expectWarning( ".toggleClass( boolean )", 1, function() {
 		e.toggleClass( false );
 		assert.ok( !e.is( ".testD.testE" ), "Assert class not present" );
 		e.toggleClass( true );

warnings.md

@@ -167,8 +167,8 @@ See jQuery-ui [commit](https://github.com/jquery/jquery-ui/commit/c0093b599fcd58
 
 **Solution:** Rename any of the older usage to `jQuery.expr.pseudos`. The functionality is identical.
 
-### JQMIGRATE: jQuery.fn.toggleClass( boolean ) is deprecated
+### JQMIGRATE: jQuery.fn.toggleClass( [ boolean ] ) is deprecated
 
-**Cause:** Calling `.toggleClass()` with no arguments or with a single Boolean `true` or `false` argument has been deprecated. Its behavior was poorly documented, but essentially the method saved away the current `class` value in a data item when the class was removed and restored the saved value when it was toggled back. If you do not believe you are specificially trying to use this form of the method, it is possible you are accidentally doing so via an inadvertent undefined value, as `.toggleClass( undefined )` toggles all classes.
+**Cause:** Calling `.toggleClass()` with no arguments, or with a single Boolean `true` or `false` argument, has been deprecated. Its behavior was poorly documented, but essentially the method saved away the current `class` value in a data item when the class was removed and restored the saved value when it was toggled back. If you do not believe you are specificially trying to use this form of the method, it is possible you are accidentally doing so via an inadvertent undefined value, as `.toggleClass( undefined )` toggles all classes.
 
 **Solution:** If this functionality is still needed, save the current full `.attr( "class" )` value in a data item and restore it when required.