From 95448204d5a2165a44fb5f4cc15c03d9bbf0abec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Sat, 16 May 2020 08:19:57 +0200 Subject: [PATCH] Tests: Fix offset tests in jQuery 3.0-3.1 `.offset()` in jQuery 3.0.0-3.1.1 sometimes returns an object with more than just `top` & `left` properties. This was fixed in jQuery 3.2.0. Since we're not in a business of fixing older jQuery versions here, this commit updates the test instead. Ref jquery/jquery#3367 Ref gh-352 --- test/offset.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/offset.js b/test/offset.js index 8b70b6d0..31dfd4b7 100644 --- a/test/offset.js +++ b/test/offset.js @@ -2,7 +2,7 @@ QUnit.module( "offset" ); QUnit.test( ".offset()", function( assert ) { - assert.expect( 20 ); + assert.expect( 21 ); var bogus = { top: 0, left: 0 }; @@ -40,7 +40,8 @@ QUnit.test( ".offset()", function( assert ) { expectWarning( assert, ".offset() as setter on disconnected node", 2, function() { - var $elemInitial = jQuery( "
" ) + var offset, + $elemInitial = jQuery( "
" ) .css( "position", "fixed" ), $elem = $elemInitial .offset( { top: 42, left: 99 } ); @@ -49,7 +50,9 @@ QUnit.test( ".offset()", function( assert ) { ".offset() returns a proper jQuery object" ); $elem.appendTo( "#qunit-fixture" ); - assert.deepEqual( $elem.offset(), { top: 42, left: 99 } ); + offset = $elem.offset(); + assert.strictEqual( offset.top, 42, "proper top offset" ); + assert.strictEqual( offset.left, 99, "proper left offset" ); } ); expectWarning( assert, ".offset() on empty set", 2, function() {