Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 6161878

Browse files
Textinput: Always wrap input in a div. This fixes: alignment of full width inputs on old IE/WP, input type color on Chrome, input type file on FF, inputs with and without clear button equal height.
1 parent 1ef2c51 commit 6161878

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

css/structure/jquery.mobile.forms.textinput.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
label.ui-input-text { font-size: 16px; line-height: 1.4; display: block; font-weight: normal; margin: 0 0 .3em; }
2-
input.ui-input-text, textarea.ui-input-text { background-image: none; padding: .4em; margin: .5em 0; min-height: 2.2em; line-height: 1.4em; font-size: 16px; display: block; width: 100%; outline: 0; }
2+
input.ui-input-text, textarea.ui-input-text { background-image: none; padding: .4em; margin: .5em 0; min-height: 1.4em; line-height: 1.4em; font-size: 16px; display: block; width: 100%; outline: 0; }
33
input.ui-mini, .ui-mini input, textarea.ui-mini { font-size: 14px; }
44
div.ui-input-text input.ui-input-text, div.ui-input-text textarea.ui-input-text,
55
.ui-input-search input.ui-input-text { border: none; width: 100%; padding: .4em 0; margin: 0; display: block; background: transparent none; outline: 0 !important; }
66
.ui-input-search, div.ui-input-text { margin: .5em 0; background-image: none; position: relative; }
77
.ui-input-search { padding: 0 30px; }
8-
div.ui-input-text input.ui-input-text { padding: .4em 30px .4em .4em; }
8+
div.ui-input-text { padding: 0 30px 0 .4em; }
99
input.ui-input-text.ui-mini, textarea.ui-input-text.ui-mini,
1010
.ui-input-search.ui-mini, div.ui-input-text.ui-mini { margin: .25em 0; }
1111
.ui-field-contain input.ui-input-text, .ui-field-contain textarea.ui-input-text,
1212
.ui-field-contain .ui-input-search, .ui-field-contain div.ui-input-text { margin: 0; }
13-
input.ui-input-text, textarea.ui-input-text, .ui-input-search, div.ui-input-text { -webkit-box-sizing: border-box; -moz-box-sizing: border-box; -ms-box-sizing: border-box; box-sizing: border-box; }
13+
textarea.ui-input-text { -webkit-box-sizing: border-box; -moz-box-sizing: border-box; -ms-box-sizing: border-box; box-sizing: border-box; }
1414
input.ui-input-text { -webkit-appearance: none; }
1515
textarea.ui-input-text { height: 50px; -webkit-transition: height 200ms linear; -moz-transition: height 200ms linear; -o-transition: height 200ms linear; transition: height 200ms linear; }
1616
textarea.ui-mini { height: 45px; }

js/widgets/forms/textinput.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ $.widget( "mobile.textinput", $.mobile.widget, {
6464
//"search" and "text" input widgets
6565
if ( isSearch ) {
6666
focusedEl = input.wrap( "<div class='ui-input-search ui-shadow-inset ui-btn-corner-all ui-btn-shadow ui-icon-searchfield" + themeclass + miniclass + "'></div>" ).parent();
67-
} else if ( inputNeedsClearBtn ) {
67+
} else if ( input.is( "input" ) ) {
6868
focusedEl = input.wrap( "<div class='ui-input-text ui-shadow-inset ui-corner-all ui-btn-shadow" + themeclass + miniclass + "'></div>" ).parent();
6969
}
7070

@@ -91,7 +91,7 @@ $.widget( "mobile.textinput", $.mobile.widget, {
9191

9292
input.bind( "paste cut keyup focus change blur", toggleClear );
9393
}
94-
else if ( !inputNeedsClearBtn && !isSearch ) {
94+
else if ( input.is( "textarea" ) ) {
9595
input.addClass( "ui-corner-all ui-shadow-inset" + themeclass + miniclass );
9696
}
9797

0 commit comments

Comments
 (0)