This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Popup transition direction reverse #4903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jquery-archive#4743 - Popup transition direction reverse by adding support for data-direction="reverse" on popup widget links.
|
@chromepenguin - Thanks for your PR! See my comment here #4743 |
|
The slide transition can be used with reverse for left to right direction but when it transitions back it doesn't go from right to left. It should go from right to left on the way back. This especially noticeable for a popup. Can someone fix it please? |
|
Could you open a new issue for that and include a test page? See our Contributing Guidelines. Thanks! |
|
Thank you for guiding me. Issue #5134 has been logged |
|
there are conflicts here and this is old closing but will be happy to review if PR is updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #4743 - Popup transition direction reverse by adding support for
data-direction="reverse" on popup widget links.