From e80bdc1f97681d8a014a5fd7110a47d977757723 Mon Sep 17 00:00:00 2001 From: Ghislain Seguin Date: Thu, 12 Dec 2013 17:33:37 -0700 Subject: [PATCH 1/2] `complete` function should be a method of the Release singleton so projects can override it Fixes #9 --- release.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/release.js b/release.js index 50c66f6..00521f2 100644 --- a/release.js +++ b/release.js @@ -58,13 +58,15 @@ stableTasks = [ Release._walk( commonTasks, function() { if ( Release.preRelease ) { - return complete(); + return Release.complete(); } - Release._walk( stableTasks, complete ); + Release._walk( stableTasks, Release.complete ); }); -function complete() { - console.log( "Release complete." ); - console.log( "Please review the project-specific release checklist." ); -} +Release.define({ + complete: function() { + console.log( "Release complete." ); + console.log( "Please review the project-specific release checklist." ); + } +}); From 6a137129c94384ae4dd0aa88741a9918c9079aed Mon Sep 17 00:00:00 2001 From: Ghislain Seguin Date: Mon, 16 Dec 2013 08:09:00 -0700 Subject: [PATCH 2/2] Release: made `complete` a method of `Release` Fixes gh-9 --- release.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/release.js b/release.js index 00521f2..123016f 100644 --- a/release.js +++ b/release.js @@ -7,6 +7,10 @@ var commonTasks, stableTasks, for ( var prop in props ) { Release[ prop ] = props[ prop ]; } + }, + complete: function() { + console.log( "Release complete." ); + console.log( "Please review the project-specific release checklist." ); } }; @@ -63,10 +67,3 @@ Release._walk( commonTasks, function() { Release._walk( stableTasks, Release.complete ); }); - -Release.define({ - complete: function() { - console.log( "Release complete." ); - console.log( "Please review the project-specific release checklist." ); - } -});