Skip to content

Commit 06f721b

Browse files
committed
Use .children() instead of .find() to manipulate accordion icons. Fixes #4645 - Accordion should only manipulate Icons that are children of ui-accordion-header
1 parent 56aecac commit 06f721b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ui/jquery.ui.accordion.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ $.widget("ui.accordion", {
129129
var o = this.options;
130130
if (o.icons) {
131131
$("<span/>").addClass("ui-icon " + o.icons.header).prependTo(this.headers);
132-
this.active.find(".ui-icon").toggleClass(o.icons.header).toggleClass(o.icons.headerSelected);
132+
this.active.children(".ui-icon").toggleClass(o.icons.header).toggleClass(o.icons.headerSelected);
133133
this.element.addClass("ui-accordion-icons");
134134
}
135135
},
@@ -279,7 +279,7 @@ $.widget("ui.accordion", {
279279
if (!o.collapsible)
280280
return;
281281
this.active.removeClass("ui-state-active ui-corner-top").addClass("ui-state-default ui-corner-all")
282-
.find(".ui-icon").removeClass(o.icons.headerSelected).addClass(o.icons.header);
282+
.children(".ui-icon").removeClass(o.icons.headerSelected).addClass(o.icons.header);
283283
this.active.next().addClass('ui-accordion-content-active');
284284
var toHide = this.active.next(),
285285
data = {
@@ -309,10 +309,10 @@ $.widget("ui.accordion", {
309309

310310
// switch classes
311311
this.active.removeClass("ui-state-active ui-corner-top").addClass("ui-state-default ui-corner-all")
312-
.find(".ui-icon").removeClass(o.icons.headerSelected).addClass(o.icons.header);
312+
.children(".ui-icon").removeClass(o.icons.headerSelected).addClass(o.icons.header);
313313
if (!clickedIsActive) {
314314
clicked.removeClass("ui-state-default ui-corner-all").addClass("ui-state-active ui-corner-top")
315-
.find(".ui-icon").removeClass(o.icons.header).addClass(o.icons.headerSelected);
315+
.children(".ui-icon").removeClass(o.icons.header).addClass(o.icons.headerSelected);
316316
clicked.next().addClass('ui-accordion-content-active');
317317
}
318318

0 commit comments

Comments
 (0)