Skip to content

Commit 0964ddd

Browse files
committed
fixup! split up jquerys to avoid browserstack timeout
1 parent 47a5412 commit 0964ddd

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.github/workflows/browserstack.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
NODE_VERSION: 20.x
1717
name: ${{ matrix.BROWSER }}
1818
concurrency:
19-
group: ${{ github.sha }}-${{ matrix.BROWSER }}
20-
timeout-minutes: 90
19+
group: ${{ github.sha }}-${{ matrix.BROWSER }}-${{ matrix.JQUERYS.name }}
20+
timeout-minutes: 30
2121
strategy:
2222
fail-fast: false
2323
matrix:
@@ -34,6 +34,11 @@ jobs:
3434
- 'Opera_latest-1'
3535
- 'Safari_latest'
3636
- 'Safari_latest-1'
37+
JQUERYS:
38+
- versions: '--jquery 3.x-git --jquery git --jquery 3.7.1 --jquery 3.6.4 --jquery 3.5.1 --jquery 3.4.1 --jquery 3.3.1 --jquery 3.2.1 --jquery 3.1.1 --jquery 3.0.0'
39+
name: 'jQuery 3.x'
40+
- versions: '--jquery 2.2.4 --jquery 1.12.4 --jquery 2.1.4 --jquery 1.11.3 --jquery 2.0.3 --jquery 1.10.2 --jquery 1.9.1 --jquery 1.8.3'
41+
name: 'jQuery 1.x/2.x'
3742

3843
steps:
3944
- name: Checkout
@@ -62,10 +67,6 @@ jobs:
6267
run: |
6368
npm run test:unit -- -v \
6469
--browserstack "${{ matrix.BROWSER }}" \
65-
--jquery 3.x-git --jquery git \
66-
--jquery 3.7.1 --jquery 3.6.4 --jquery 3.5.1 --jquery 3.4.1 \
67-
--jquery 3.3.1 --jquery 3.2.1 --jquery 3.1.1 --jquery 3.0.0 \
68-
--jquery 2.2.4 --jquery 1.12.4 --jquery 2.1.4 --jquery 1.11.3 \
69-
--jquery 2.0.3 --jquery 1.10.2 --jquery 1.9.1 --jquery 1.8.3 \
70+
${{ matrix.JQUERYS.versions }} \
7071
--run-id ${{ github.run_id }} \
7172
--retries 3 --hard-retries 1

tests/runner/browsers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export async function createBrowserWorker( url, browser, options, restarts = 0 )
6464
worker = await createWorker( {
6565
...browser,
6666
url: encodeURI( url ),
67-
project: "jquery",
67+
project: "jquery-ui",
6868
build: `Run ${ runId }`,
6969

7070
// This is the maximum timeout allowed

tests/runner/run.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ export async function run( {
277277

278278
for ( const browser of browsers ) {
279279
for ( const suite of suites ) {
280-
queueRuns( [ suite ], browser );
280+
queueRuns( suite, browser );
281281
}
282282
}
283283

0 commit comments

Comments
 (0)