Skip to content

Commit 15a9ed7

Browse files
committed
Droppable: Use new has/lacksClasses assertions for all class checks
1 parent 2d5857c commit 15a9ed7

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

tests/unit/droppable/droppable.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<script src="../../../external/qunit/qunit.js"></script>
1313
<script src="../../../external/jquery-simulate/jquery.simulate.js"></script>
1414
<script src="../testsuite.js"></script>
15+
<script src="../../../external/qunit-assert-classes/qunit-assert-classes.js"></script>
1516
<script>
1617
TestHelpers.loadResources({
1718
css: [ "core" ],

tests/unit/droppable/droppable_events.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module( "droppable: events" );
44

5-
test( "droppable destruction/recreation on drop event", function() {
5+
test( "droppable destruction/recreation on drop event", function( assert ) {
66
expect( 1 );
77

88
var config = {
@@ -32,7 +32,7 @@ test( "droppable destruction/recreation on drop event", function() {
3232
dy: dy
3333
});
3434

35-
ok( !droppable2.hasClass( "active" ), "subsequent droppable no longer active" );
35+
assert.lacksClasses( droppable2, "active", "subsequent droppable no longer active" );
3636
});
3737

3838
// todo: comment the following in when ready to actually test

tests/unit/droppable/droppable_methods.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ test("enable", function() {
6363
equal(actual, expected, "enable is chainable");
6464
});
6565

66-
test( "disable", function() {
66+
test( "disable", function( assert ) {
6767
expect( 10 );
6868

6969
var actual, expected,
@@ -77,9 +77,9 @@ test( "disable", function() {
7777
element.droppable({ disabled: false });
7878
TestHelpers.droppable.shouldDrop();
7979
element.droppable( "option", "disabled", true );
80-
ok( !element.droppable( "widget" ).hasClass( "ui-state-disabled" ), "element does not get ui-state-disabled" );
80+
assert.lacksClasses( element.droppable( "widget" ), "ui-state-disabled" );
8181
ok( !element.droppable( "widget" ).attr( "aria-disabled" ), "element does not get aria-disabled" );
82-
ok( element.droppable( "widget" ).hasClass( "ui-droppable-disabled" ), "element gets ui-droppable-disabled" );
82+
assert.hasClasses( element.droppable( "widget" ), "ui-droppable-disabled" );
8383
equal( element.droppable( "option", "disabled" ), true, "disabled option setter" );
8484
TestHelpers.droppable.shouldNotDrop();
8585

tests/unit/droppable/droppable_options.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,18 @@ test( "activeClass", function() {
2222
ok(false, 'missing test - untested code is broken code');
2323
});
2424
*/
25-
test( "{ addClasses: true }, default", function() {
25+
test( "{ addClasses: true }, default", function( assert ) {
2626
expect( 1 );
2727
var el = $( "<div />" ).droppable({ addClasses: true });
28-
ok( el.is( ".ui-droppable" ), "'ui-droppable' class added" );
28+
assert.hasClasses( el, "ui-droppable" );
2929
el.droppable( "destroy" );
3030
});
3131

32-
test( "{ addClasses: false }", function() {
32+
test( "{ addClasses: false }", function( assert ) {
3333
expect( 1 );
3434
var el = $( "<div />" ).droppable({ addClasses: false });
35-
ok( !el.is( ".ui-droppable" ), "'ui-droppable' class not added" );
35+
36+
assert.lacksClasses( el, "ui-droppable" );
3637
el.droppable( "destroy" );
3738
});
3839

0 commit comments

Comments
 (0)