Skip to content

Commit 197061b

Browse files
committed
Button: address review comments
1 parent c5d6ea4 commit 197061b

File tree

5 files changed

+10
-97
lines changed

5 files changed

+10
-97
lines changed

demos/button/icons.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,20 @@
88
<link rel="stylesheet" href="../demos.css">
99
<script src="../../external/requirejs/require.js"></script>
1010
<script src="../bootstrap.js">
11-
$( ".widget button" ).first()
12-
.button()
13-
.next().button( {
11+
$( ".widget button" )
12+
.eq( 0 ).button()
13+
.end().eq( 1 ).button( {
1414
icon: "ui-icon-gear",
1515
showLabel: false
16-
} ).next().button( {
16+
} ).end().eq( 2 ).button( {
1717
icon: "ui-icon-gear"
18-
} ).next().button( {
18+
} ).end().eq( 3 ).button( {
1919
icon: "ui-icon-gear",
2020
iconPosition: "end"
21-
} ).next().button( {
21+
} ).end().eq( 4 ).button( {
2222
icon: "ui-icon-gear",
2323
iconPosition: "top"
24-
} ).next().button( {
24+
} ).end().eq( 5 ).button( {
2525
icon: "ui-icon-gear",
2626
iconPosition: "bottom"
2727
} );

tests/visual/button/button.html

Lines changed: 0 additions & 67 deletions
This file was deleted.

tests/visual/button/performance.html

Lines changed: 0 additions & 21 deletions
This file was deleted.

themes/base/button.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ input.ui-button.ui-icon-notext .ui-icon {
7474
}
7575

7676
/* workarounds */
77-
/* Support: FireFox >= 4 */
77+
/* Support: Firefox 5 - 40 */
7878
input.ui-button::-moz-focus-inner,
7979
button.ui-button::-moz-focus-inner {
8080
border: 0;

ui/widgets/button.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
//>>description: Enhances a form with themeable buttons.
1313
//>>docs: http://api.jqueryui.com/button/
1414
//>>demos: http://jqueryui.com/button/
15-
//>>css.structure: ../themes/base/core.css, ../themes/base/button.css
15+
//>>css.structure: ../themes/base/core.css
16+
//>>css.structure: ../themes/base/button.css
1617
//>>css.theme: ../themes/base/theme.css
1718

1819
( function( factory ) {

0 commit comments

Comments
 (0)