Skip to content

Commit 2084549

Browse files
allproscottgonzalez
authored andcommitted
Effects: set right/bottom to 'auto' so effects work with dir=rtl. Fixed #6736 - Bug in slide effect when dir=rtl and has position.right.
1 parent f73d421 commit 2084549

9 files changed

+10
-10
lines changed

ui/jquery.effects.blind.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.blind = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left'];
20+
var el = $(this), props = ['position','top','bottom','left','right'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode

ui/jquery.effects.bounce.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.bounce = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left'];
20+
var el = $(this), props = ['position','top','bottom','left','right'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'effect'); // Set Mode

ui/jquery.effects.clip.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.clip = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left','height','width'];
20+
var el = $(this), props = ['position','top','bottom','left','right','height','width'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode

ui/jquery.effects.core.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ $.extend($.effects, {
390390
props[pos] = 'auto';
391391
}
392392
});
393-
element.css({position: 'relative', top: 0, left: 0 });
393+
element.css({position: 'relative', top: 0, left: 0, right: 'auto', bottom: 'auto' });
394394
}
395395

396396
return wrapper.css(props).show();

ui/jquery.effects.drop.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.drop = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left','opacity'];
20+
var el = $(this), props = ['position','top','bottom','left','right','opacity'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode

ui/jquery.effects.fold.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.fold = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left'];
20+
var el = $(this), props = ['position','top','bottom','left','right'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode

ui/jquery.effects.scale.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ $.effects.size = function(o) {
8484
return this.queue(function() {
8585

8686
// Create element
87-
var el = $(this), props = ['position','top','left','width','height','overflow','opacity'];
88-
var props1 = ['position','top','left','overflow','opacity']; // Always restore
87+
var el = $(this), props = ['position','top','bottom','left','right','width','height','overflow','opacity'];
88+
var props1 = ['position','top','bottom','left','right','overflow','opacity']; // Always restore
8989
var props2 = ['width','height','overflow']; // Copy for children
9090
var cProps = ['fontSize'];
9191
var vProps = ['borderTopWidth', 'borderBottomWidth', 'paddingTop', 'paddingBottom'];

ui/jquery.effects.shake.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.shake = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left'];
20+
var el = $(this), props = ['position','top','bottom','left','right'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'effect'); // Set Mode

ui/jquery.effects.slide.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $.effects.slide = function(o) {
1717
return this.queue(function() {
1818

1919
// Create element
20-
var el = $(this), props = ['position','top','left'];
20+
var el = $(this), props = ['position','top','bottom','left','right'];
2121

2222
// Set options
2323
var mode = $.effects.setMode(el, o.options.mode || 'show'); // Set Mode

0 commit comments

Comments
 (0)