Skip to content

Commit 2ca4d17

Browse files
committed
Effects Core: make removeClass work correctly with changes jQuery 1.9.0. Fixed #9015 - Inclusion of jQuery UI breaks removeClass
1 parent 3aa8ad0 commit 2ca4d17

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

tests/unit/effects/effects_core.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ asyncTest( "Parse of null for options", function() {
3838
});
3939
});
4040

41+
test( "removeClass", function() {
42+
expect( 3 );
43+
44+
var element = $( "<div>" );
45+
equal( "", element[ 0 ].className );
46+
element.addClass( "destroyed" );
47+
equal( "destroyed", element[ 0 ].className );
48+
element.removeClass();
49+
equal( "", element[ 0 ].className );
50+
});
51+
4152

4253
/* TODO: Disabled - Can't figure out why this is failing in IE 6/7
4354
test( "createWrapper and removeWrapper retain focused elements (#7595)", function() {

ui/jquery.ui.effect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -849,10 +849,10 @@ $.fn.extend({
849849

850850
_removeClass: $.fn.removeClass,
851851
removeClass: function( classNames, speed, easing, callback ) {
852-
return speed ?
852+
return arguments.length > 1 ?
853853
$.effects.animateClass.call( this,
854854
{ remove: classNames }, speed, easing, callback ) :
855-
this._removeClass( classNames );
855+
this._removeClass.apply( this, arguments );
856856
},
857857

858858
_toggleClass: $.fn.toggleClass,

0 commit comments

Comments
 (0)