Slider: fixed step alignment to handle negative fractional values. Fixed #5583 - Slider displays negative fractional values incorrectly. Thanks for the patch watanabe.

rdworth · rdworth · commit 34912bc933d2 · 2010-05-11T08:17:18.000-04:00
diff --git a/ui/jquery.ui.slider.js b/ui/jquery.ui.slider.js
@@ -591,12 +591,12 @@ $.widget( "ui.slider", $.ui.mouse, {
 		if ( val > this._valueMax() ) {
 			return this._valueMax();
 		}
-		var step = this.options.step,
+		var step = ( this.options.step > 0 ) ? this.options.step : 1,
 			valModStep = val % step,
 			alignValue = val - valModStep;
 
-		if ( valModStep >= ( step / 2 ) ) {
-			alignValue += step;
+		if ( Math.abs(valModStep) * 2 >= step ) {
+			alignValue += ( valModStep > 0 ) ? step : ( -step );
 		}
 
 		// Since JavaScript has problems with large floats, round

Original file line number	Diff line number	Diff line change
`@@ -591,12 +591,12 @@ $.widget( "ui.slider", $.ui.mouse, {`
`591`	`591`	`if ( val > this._valueMax() ) {`
`592`	`592`	`return this._valueMax();`
`593`	`593`	`}`
`594`		`- var step = this.options.step,`
	`594`	`+ var step = ( this.options.step > 0 ) ? this.options.step : 1,`
`595`	`595`	`valModStep = val % step,`
`596`	`596`	`alignValue = val - valModStep;`
`597`	`597`
`598`		`- if ( valModStep >= ( step / 2 ) ) {`
`599`		`- alignValue += step;`
	`598`	`+ if ( Math.abs(valModStep) * 2 >= step ) {`
	`599`	`+ alignValue += ( valModStep > 0 ) ? step : ( -step );`
`600`	`600`	`}`
`601`	`601`
`602`	`602`	`// Since JavaScript has problems with large floats, round`