Skip to content

Commit 35e51b1

Browse files
author
Gabriel Schulhof
committed
Controlgroup: Test proper handling of non-empty class key value
1 parent 5b4b984 commit 35e51b1

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed

tests/unit/controlgroup/controlgroup.html

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,16 @@
6868
<div class="controlgroup-single-button">
6969
<button class="single-button">button</button>
7070
</div>
71+
<div class="controlgroup-non-empty-class-key">
72+
<select id="non-empty-class-key-first">
73+
<option>Option 1</option>
74+
<option>Option 2</option>
75+
</select>
76+
<select id="non-empty-class-key-second">
77+
<option>Option 1</option>
78+
<option>Option 2</option>
79+
</select>
80+
</div>
7181
</div>
7282
</body>
7383
</html>

tests/unit/controlgroup/core.js

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,4 +160,39 @@ QUnit.test( "Single controlgroup button - vertical", function( assert ) {
160160
" ui-corner-tr ui-corner-tl ui-corner-bl ui corner-br" );
161161
} );
162162

163+
QUnit.module( "Controlgroup: Non-empty class key", {
164+
setup: function() {
165+
this.classKey = $.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ];
166+
$.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ] =
167+
$.trim( $.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ] +
168+
" something-custom" );
169+
},
170+
teardown: function() {
171+
$.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ] = this.classKey;
172+
}
173+
} );
174+
175+
QUnit.test( "Controlgroup handles non-empty class key correctly", function( assert ) {
176+
assert.expect( 2 );
177+
178+
$( ".controlgroup-non-empty-class-key" )
179+
.controlgroup()
180+
.controlgroup( "instance" );
181+
182+
assert.deepEqual(
183+
( ( ( $( "#non-empty-class-key-first" )
184+
.selectmenu( "option", "classes" )[ "ui-selectmenu-button-closed" ] || "" )
185+
.match( /\S+/g ) ) || [] ).sort(),
186+
[ "something-custom", "ui-corner-left" ],
187+
"First controlgroup item has the expected value for the class key" );
188+
189+
assert.deepEqual(
190+
( ( ( $( "#non-empty-class-key-second" )
191+
.selectmenu( "option", "classes" )[ "ui-selectmenu-button-closed" ] || "" )
192+
.match( /\S+/g ) ) || [] ).sort(),
193+
[ "something-custom", "ui-corner-right" ],
194+
"Second controlgroup item has the expected value for the class key" );
195+
196+
} );
197+
163198
} );

0 commit comments

Comments
 (0)