Skip to content

Commit 4992fc9

Browse files
committed
Menu: Add ui-front on submenus to address opacity messing up stacking order. Fixes #9650 - Menu: Disabled item visible through submenu on top
1 parent 25f1685 commit 4992fc9

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

tests/visual/menu/menu.html

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,15 @@
1515
$( "<p>" ).text( "Selected: " + ui.item.text() ).appendTo( "#log" );
1616
}
1717

18-
$( "#menu1, #menu2, #menu3, .menu4" ).menu({
18+
$( "#menu1, #menu3, .menu4" ).menu({
19+
select: logger
20+
});
21+
22+
$( "#menu2" ).menu({
23+
position: {
24+
my: "left top",
25+
at: "left+10 top-20"
26+
},
1927
select: logger
2028
});
2129

@@ -39,6 +47,7 @@
3947
<style>
4048
body { font-size:62.5%; }
4149
.ui-menu { width: 200px; margin-bottom: 2em; }
50+
.menu2-container { width: 220px; }
4251
.menu4 { height: 200px; overflow-y: auto; overflow-x: hidden; }
4352
.address-item { border-bottom: 1px solid #999; }
4453
.address-header { display: block; margin-bottom: .2em; font-weight: bold; }
@@ -88,7 +97,7 @@ <h2>Inline with disabled items and submenus</h2>
8897
<li>Salzburg</li>
8998
</ul>
9099
</li>
91-
<li>Perch</li>
100+
<li class="ui-state-disabled">Perch</li>
92101
</ul>
93102
</li>
94103
<li class="ui-state-disabled">Amesville</li>

ui/jquery.ui.menu.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ $.widget( "ui.menu", {
147147
this.element
148148
.removeAttr( "aria-activedescendant" )
149149
.find( ".ui-menu" ).addBack()
150-
.removeClass( "ui-menu ui-widget ui-widget-content ui-menu-icons" )
150+
.removeClass( "ui-menu ui-widget ui-widget-content ui-menu-icons ui-front" )
151151
.removeAttr( "role" )
152152
.removeAttr( "tabIndex" )
153153
.removeAttr( "aria-labelledby" )
@@ -292,7 +292,7 @@ $.widget( "ui.menu", {
292292

293293
// Initialize nested menus
294294
submenus.filter( ":not(.ui-menu)" )
295-
.addClass( "ui-menu ui-widget ui-widget-content" )
295+
.addClass( "ui-menu ui-widget ui-widget-content ui-front" )
296296
.hide()
297297
.attr({
298298
role: this.options.role,

0 commit comments

Comments
 (0)