Skip to content

Commit 4efd006

Browse files
committed
Merge branch 'master' into selectmenu
2 parents 73c7342 + 71a332e commit 4efd006

25 files changed

+723
-443
lines changed

.jshintrc

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
{
2+
"boss": true,
23
"curly": true,
3-
"eqnull": true,
44
"eqeqeq": true,
5+
"eqnull": true,
56
"expr": true,
7+
"immed": true,
68
"noarg": true,
7-
"node": true,
89
"onevar": true,
10+
"quotmark": "double",
11+
"smarttabs": true,
912
"trailing": true,
1013
"undef": true,
11-
"unused": true
14+
"unused": true,
15+
16+
"node": true
1217
}

.mailmap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Ben Hollis <bhollis@amazon.com> <ben@benhollis.net>
1111
Benjamin Scott Boyle <benjamins.boyle@gmail.com>
1212
Bert ter Heide <bertjh@hotmail.com>
1313
Chairat Sunthornwiphat <pipo@sixhead.com>
14-
Corey Frang <gnarf@gnarf.net>
14+
Corey Frang <gnarf37@gmail.com> <gnarf@gnarf.net>
1515
Courtland Allen <courtlandallen@gmail.com>
1616
Dan Streetman <ddstreet@ieee.org>
1717
Diego Tres <diegotres@gmail.com>

Gruntfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ var
7474
},
7575
main: {
7676
options: {
77-
keepSpecialComments: '*'
77+
keepSpecialComments: "*"
7878
},
7979
src: "dist/jquery-ui.css",
8080
dest: "dist/jquery-ui.min.css"
@@ -319,7 +319,7 @@ grunt.initConfig({
319319
files: expandFiles( "tests/unit/**/*.html" ).filter(function( file ) {
320320
// disabling everything that doesn't (quite) work with PhantomJS for now
321321
// TODO except for all|index|test, try to include more as we go
322-
return !( /(all|index|test|dialog|tabs|tooltip)\.html$/ ).test( file );
322+
return !( /(all|index|test|dialog|tooltip)\.html$/ ).test( file );
323323
})
324324
},
325325
jshint: {

build/release/release.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env node
2-
/*global cat:true cd:true echo:true exec:true exit:true*/
2+
/* global cat:true, cd:true, echo:true, exec:true, exit:true */
33

44
// Usage:
55
// stable release: node release.js

build/tasks/build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ grunt.registerMultiTask( "zip", "Create a zip file for release", function() {
140140
cmd: "zip",
141141
args: [ "-r", dest, this.data.src ],
142142
opts: {
143-
cwd: 'dist'
143+
cwd: "dist"
144144
}
145145
}, function( err ) {
146146
if ( err ) {

build/tasks/testswarm.js

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -34,37 +34,40 @@ var versions = {
3434
"Widget": "widget/widget.html"
3535
};
3636

37-
function submit( commit, runs, configFile, version, done ) {
37+
function submit( commit, runs, configFile, extra, done ) {
3838
var testName,
3939
testswarm = require( "testswarm" ),
40-
config = grunt.file.readJSON( configFile ).jqueryui;
41-
version = version ? ( version + " " ) : "";
40+
config = grunt.file.readJSON( configFile ).jqueryui,
41+
commitUrl = "https://github.com/jquery/jquery-ui/commit/" + commit;
42+
43+
if ( extra ) {
44+
extra = " " + extra;
45+
}
46+
4247
for ( testName in runs ) {
43-
runs[ testName] = config.testUrl + commit + "/tests/unit/" + runs[ testName ];
48+
runs[ testName ] = config.testUrl + commit + "/tests/unit/" + runs[ testName ];
4449
}
45-
testswarm.createClient( {
50+
testswarm.createClient({
4651
url: config.swarmUrl,
4752
pollInterval: 10000,
4853
timeout: 1000 * 60 * 45
49-
} )
54+
})
5055
.addReporter( testswarm.reporters.cli )
51-
.auth( {
56+
.auth({
5257
id: config.authUsername,
5358
token: config.authToken
54-
} )
55-
.addjob(
56-
{
57-
name: 'jQuery UI ' + version + '#<a href="https://github.com/jquery/jquery-ui/commit/' + commit + '">' + commit.substr( 0, 10 ) + '</a>',
58-
runs: runs,
59-
runMax: config.runMax,
60-
browserSets: config.browserSets
61-
}, function( err, passed ) {
62-
if ( err ) {
63-
grunt.log.error( err );
64-
}
65-
done( passed );
59+
})
60+
.addjob({
61+
name: "jQuery UI #<a href='" + commitUrl + "'>" + commit.substr( 0, 10 ) + "</a>" + extra,
62+
runs: runs,
63+
runMax: config.runMax,
64+
browserSets: config.browserSets
65+
}, function( error, passed ) {
66+
if ( error ) {
67+
grunt.log.error( error );
6668
}
67-
);
69+
done( passed );
70+
});
6871
}
6972

7073
grunt.registerTask( "testswarm", function( commit, configFile ) {
@@ -83,7 +86,7 @@ grunt.registerTask( "testswarm-multi-jquery", function( commit, configFile, mino
8386
allTests[ test + "-" + version ] = tests[ test ] + "?nojshint=true&jquery=" + version;
8487
}
8588
});
86-
submit( commit, allTests, configFile, minor + " core", this.async() );
89+
submit( commit, allTests, configFile, "core " + minor, this.async() );
8790
});
8891

8992
};

demos/autocomplete/combobox.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
<script src="../../ui/jquery.ui.tooltip.js"></script>
1515
<link rel="stylesheet" href="../demos.css">
1616
<style>
17-
.ui-combobox {
17+
.custom-combobox {
1818
position: relative;
1919
display: inline-block;
2020
}
21-
.ui-combobox-toggle {
21+
.custom-combobox-toggle {
2222
position: absolute;
2323
top: 0;
2424
bottom: 0;
@@ -28,17 +28,17 @@
2828
*height: 1.7em;
2929
*top: 0.1em;
3030
}
31-
.ui-combobox-input {
31+
.custom-combobox-input {
3232
margin: 0;
3333
padding: 0.3em;
3434
}
3535
</style>
3636
<script>
3737
(function( $ ) {
38-
$.widget( "ui.combobox", {
38+
$.widget( "custom.combobox", {
3939
_create: function() {
4040
this.wrapper = $( "<span>" )
41-
.addClass( "ui-combobox" )
41+
.addClass( "custom-combobox" )
4242
.insertAfter( this.element );
4343

4444
this.element.hide();
@@ -54,7 +54,7 @@
5454
.appendTo( this.wrapper )
5555
.val( value )
5656
.attr( "title", "" )
57-
.addClass( "ui-state-default ui-combobox-input ui-widget ui-widget-content ui-corner-left" )
57+
.addClass( "custom-combobox-input ui-widget ui-widget-content ui-state-default ui-corner-left" )
5858
.autocomplete({
5959
delay: 0,
6060
minLength: 0,
@@ -92,7 +92,7 @@
9292
text: false
9393
})
9494
.removeClass( "ui-corner-all" )
95-
.addClass( "ui-corner-right ui-combobox-toggle" )
95+
.addClass( "custom-combobox-toggle ui-corner-right" )
9696
.mousedown(function() {
9797
wasOpen = input.autocomplete( "widget" ).is( ":visible" );
9898
})

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"dependencies": {},
5555
"devDependencies": {
5656
"grunt": "0.4.1",
57-
"grunt-contrib-jshint": "0.1.1",
57+
"grunt-contrib-jshint": "0.4.1",
5858
"grunt-contrib-uglify": "0.1.1",
5959
"grunt-contrib-concat": "0.1.3",
6060
"grunt-contrib-qunit": "0.2.0",

tests/.jshintrc

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,22 @@
11
{
2-
"browser": true,
2+
"boss": true,
33
"curly": true,
4-
"eqnull": true,
54
"eqeqeq": true,
5+
"eqnull": true,
66
"expr": true,
7-
"evil": true,
8-
"jquery": true,
9-
"latedef": true,
7+
"immed": true,
108
"noarg": true,
119
"onevar": true,
1210
"quotmark": "double",
11+
"smarttabs": true,
1312
"trailing": true,
1413
"undef": true,
1514
"unused": true,
15+
16+
"browser": true,
17+
"evil": true,
18+
"jquery": true,
19+
1620
"globals": {
1721
"asyncTest": false,
1822
"closeEnough": false,
@@ -34,4 +38,4 @@
3438
"TestHelpers": true,
3539
"JSHINT": false
3640
}
37-
}
41+
}

tests/jquery.simulate.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,8 +316,12 @@ $.extend( $.simulate.prototype, {
316316
this.simulateEvent( document, "mousemove", coord );
317317
}
318318

319-
this.simulateEvent( target, "mouseup", coord );
320-
this.simulateEvent( target, "click", coord );
319+
if ( $.contains( document, target ) ) {
320+
this.simulateEvent( target, "mouseup", coord );
321+
this.simulateEvent( target, "click", coord );
322+
} else {
323+
this.simulateEvent( document, "mouseup", coord );
324+
}
321325
}
322326
});
323327

0 commit comments

Comments
 (0)