Skip to content

Commit 6231b16

Browse files
committed
Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order for it to work properly in IE8.
1 parent 45797b9 commit 6231b16

File tree

27 files changed

+44
-25
lines changed

27 files changed

+44
-25
lines changed

Gruntfile.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,8 @@ grunt.initConfig({
239239
"ui/*.js",
240240
"Gruntfile.js",
241241
"build/**/*.js",
242-
"tests/unit/**/*.js"
242+
"tests/unit/**/*.js",
243+
"tests/lib/**/*.js"
243244
]
244245
},
245246
csslint: {

tests/.jshintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"expr": true,
77
"immed": true,
88
"noarg": true,
9-
"onevar": true,
109
"quotmark": "double",
1110
"smarttabs": true,
1211
"trailing": true,
@@ -31,6 +30,8 @@
3130
"notStrictEqual": false,
3231
"ok": false,
3332
"QUnit": true,
33+
"require": true,
34+
"requirejs": true,
3435
"start": false,
3536
"strictEqual": false,
3637
"stop": false,

tests/lib/bootstrap.js

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
( function() {
22

3-
window.requirejs = {
3+
requirejs.config({
44
paths: {
55
"globalize": "../../../external/globalize/globalize",
66
"globalize/ja-JP": "../../../external/globalize/globalize.culture.ja-JP",
@@ -20,7 +20,19 @@ window.requirejs = {
2020
"qunit-assert-classes": [ "qunit" ],
2121
"qunit-assert-close": [ "qunit" ]
2222
}
23-
};
23+
});
24+
25+
// Create a module that disables back compat for UI modules
26+
define( "jquery-no-back-compat", [ "jquery" ], function( $ ) {
27+
$.uiBackCompat = false;
28+
29+
return $;
30+
} );
31+
32+
// Create a dummy bridge if we're not actually testing in PhantomJS
33+
if ( !/PhantomJS/.test( navigator.userAgent ) ) {
34+
define( "phantom-bridge", function() {} );
35+
}
2436

2537
// Load all modules in series
2638
function requireModules( dependencies, callback, modules ) {
@@ -83,7 +95,7 @@ function jqueryUrl() {
8395
}
8496

8597
return url;
86-
};
98+
}
8799

88100
function swarmInject() {
89101
var url = parseUrl().swarmURL;
@@ -134,26 +146,7 @@ function swarmInject() {
134146
}
135147
}
136148

137-
// Load requirejs, then load the tests
138-
script = document.createElement( "script" );
139-
script.src = "../../../external/requirejs/require.js";
140-
script.onload = function() {
141-
142-
// Create a module that disables back compat for UI modules
143-
define( "jquery-no-back-compat", [ "jquery" ], function( $ ) {
144-
$.uiBackCompat = false;
145-
146-
return $;
147-
} );
148-
149-
// Create a dummy bridge if we're not actually testing in PhantomJS
150-
if ( !/PhantomJS/.test( navigator.userAgent ) ) {
151-
define( "phantom-bridge", function() {} );
152-
}
153-
154-
requireTests( modules, noBackCompat );
155-
};
156-
document.documentElement.appendChild( script );
149+
requireTests( modules, noBackCompat );
157150
} )();
158151

159152
} )();

tests/unit/accordion/accordion.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Accordion Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core accordion"></script>
89
<script src="../../lib/bootstrap.js" data-widget="accordion"></script>
910
<style>

tests/unit/autocomplete/autocomplete.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Autocomplete Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core menu autocomplete"></script>
89
<script src="../../lib/bootstrap.js" data-widget="autocomplete"></script>
910
</head>

tests/unit/button/button.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Button Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core button"></script>
89
<script src="../../lib/bootstrap.js" data-widget="button"></script>
910
</head>

tests/unit/core/core.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Core Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js"></script>
89
<script src="../../lib/bootstrap.js" data-modules="core selector"></script>
910
<style>

tests/unit/datepicker/datepicker.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Datepicker Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core datepicker"></script>
89
<script src="../../lib/bootstrap.js" data-widget="datepicker"></script>
910
</head>

tests/unit/dialog/deprecated.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Dialog Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core button dialog"></script>
89
<script src="../../lib/bootstrap.js" data-widget="dialog" data-deprecated="true"></script>
910
</head>

tests/unit/dialog/dialog.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Dialog Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core button dialog"></script>
89
<script src="../../lib/bootstrap.js" data-widget="dialog" data-no-back-compat="true"></script>
910
</head>

tests/unit/draggable/draggable.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Draggable Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core"></script>
89
<script src="../../lib/bootstrap.js" data-widget="draggable"></script>
910
<style>

tests/unit/droppable/deprecated.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Droppable Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core"></script>
89
<script src="../../lib/bootstrap.js" data-widget="droppable" data-deprecated="true"></script>
910
</head>

tests/unit/droppable/droppable.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Droppable Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core"></script>
89
<script src="../../lib/bootstrap.js" data-widget="droppable"
910
data-no-back-compat="true"></script>

tests/unit/effects/effects.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Effects Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js"></script>
89
<script src="../../lib/bootstrap.js" data-modules="core scale">
910
</script>

tests/unit/menu/menu.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Menu Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core menu"></script>
89
<script src="../../lib/bootstrap.js" data-widget="menu"></script>
910
<style>

tests/unit/position/position.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Position Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js"></script>
89
<script src="../../lib/bootstrap.js" data-modules="core"></script>
910
</head>

tests/unit/progressbar/progressbar.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Progressbar Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core progressbar"></script>
89
<script src="../../lib/bootstrap.js" data-widget="progressbar"></script>
910
</head>

tests/unit/resizable/resizable.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Resizable Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core resizable"></script>
89
<script src="../../lib/bootstrap.js" data-widget="resizable"></script>
910
<style>

tests/unit/selectable/selectable.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Selectable Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core selectable"></script>
89
<script src="../../lib/bootstrap.js" data-widget="selectable"></script>
910
</head>

tests/unit/selectmenu/selectmenu.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Selectmenu Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core menu selectmenu"></script>
89
<script src="../../lib/bootstrap.js" data-widget="selectmenu"></script>
910
</head>

tests/unit/slider/slider.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Slider Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core slider"></script>
89
<script src="../../lib/bootstrap.js" data-widget="slider"></script>
910
</head>

tests/unit/sortable/sortable.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Sortable Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core"></script>
89
<script src="../../lib/bootstrap.js" data-widget="sortable"></script>
910
<style>

tests/unit/spinner/spinner.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Spinner Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core button spinner"></script>
89
<script src="../../lib/bootstrap.js" data-widget="spinner"></script>
910
</head>

tests/unit/tabs/tabs.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Tabs Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core tabs"></script>
89
<script src="../../lib/bootstrap.js" data-widget="tabs"></script>
910
<style>

tests/unit/tooltip/deprecated.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Tooltip Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core tooltip"></script>
89
<script src="../../lib/bootstrap.js" data-widget="tooltip" data-deprecated="true"></script>
910
</head>

tests/unit/tooltip/tooltip.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Tooltip Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core tooltip"></script>
89
<script src="../../lib/bootstrap.js" data-widget="tooltip" data-no-back-compat="true"></script>
910
</head>

tests/unit/widget/widget.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Widget Test Suite</title>
66

7+
<script src="../../../external/requirejs/require.js"></script>
78
<script src="../../lib/css.js" data-modules="core"></script>
89
<script src="../../lib/bootstrap.js" data-modules="core extend animation classes">
910
</script>

0 commit comments

Comments
 (0)