Skip to content

Commit 69ed8ab

Browse files
committed
Tabs: Convert tests to new infrastructure
1 parent a3222d1 commit 69ed8ab

File tree

7 files changed

+51
-47
lines changed

7 files changed

+51
-47
lines changed

tests/unit/tabs/tabs.html

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,8 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Tabs Test Suite</title>
66

7-
<script src="../../jquery.js"></script>
8-
<link rel="stylesheet" href="../../../external/qunit/qunit.css">
9-
<script src="../../../external/qunit/qunit.js"></script>
10-
<script src="../../../external/jquery-simulate/jquery.simulate.js"></script>
11-
<script src="../testsuite.js"></script>
12-
<script src="../../../external/qunit-assert-classes/qunit-assert-classes.js"></script>
13-
<script>
14-
TestHelpers.loadResources({
15-
css: [ "core", "tabs" ],
16-
js: [
17-
"ui/core.js",
18-
"ui/widget.js",
19-
"ui/tabs.js"
20-
]
21-
});
22-
</script>
23-
24-
<script src="tabs_test_helpers.js"></script>
25-
<script src="tabs_common.js"></script>
26-
<script src="tabs_core.js"></script>
27-
<script src="tabs_events.js"></script>
28-
<script src="tabs_methods.js"></script>
29-
<script src="tabs_options.js"></script>
30-
31-
<script src="../swarminject.js"></script>
7+
<script src="../../lib/css.js" data-modules="core tabs"></script>
8+
<script src="../../lib/bootstrap.js" data-widget="tabs"></script>
329
<style>
3310
#tabs8, #tabs8 * {
3411
margin: 0;

tests/unit/tabs/tabs_common.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
TestHelpers.commonWidgetTests( "tabs", {
1+
define( [
2+
"lib/common",
3+
"ui/tabs"
4+
], function( common ) {
5+
6+
common.testWidget( "tabs", {
27
defaults: {
38
active: null,
49
classes: {
@@ -22,3 +27,5 @@ TestHelpers.commonWidgetTests( "tabs", {
2227
load: null
2328
}
2429
});
30+
31+
} );

tests/unit/tabs/tabs_core.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./tabs_test_helpers",
4+
"ui/tabs"
5+
], function( $, tabsTestHelpers ) {
26

3-
var state = TestHelpers.tabs.state;
7+
var state = tabsTestHelpers.state;
48

59
module( "tabs: core" );
610

@@ -660,4 +664,4 @@ test( "#4033 - IE expands hash to full url and misinterprets tab as ajax", funct
660664
state( element, 1 );
661665
});
662666

663-
}( jQuery ) );
667+
} );

tests/unit/tabs/tabs_events.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./tabs_test_helpers",
4+
"ui/tabs"
5+
], function( $, tabsTestHelpers ) {
26

3-
var state = TestHelpers.tabs.state;
7+
var state = tabsTestHelpers.state;
48

59
module( "tabs: events" );
610

@@ -315,4 +319,4 @@ asyncTest( "load", function() {
315319
}
316320
});
317321

318-
}( jQuery ) );
322+
} );

tests/unit/tabs/tabs_methods.js

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,27 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./tabs_test_helpers",
4+
"ui/tabs"
5+
], function( $, tabsTestHelpers ) {
26

3-
var disabled = TestHelpers.tabs.disabled,
4-
state = TestHelpers.tabs.state;
7+
var disabled = tabsTestHelpers.disabled,
8+
state = tabsTestHelpers.state;
59

610
module( "tabs: methods" );
711

8-
test( "destroy", function() {
12+
test( "destroy", function( assert ) {
913
expect( 2 );
10-
domEqual( "#tabs1", function() {
14+
assert.domEqual( "#tabs1", function() {
1115
$( "#tabs1" ).tabs().tabs( "destroy" );
1216
});
13-
domEqual( "#tabs2", function() {
17+
assert.domEqual( "#tabs2", function() {
1418
$( "#tabs2" ).tabs().tabs( "destroy" );
1519
});
1620
});
1721

18-
asyncTest( "destroy - ajax", function() {
22+
asyncTest( "destroy - ajax", function( assert ) {
1923
expect( 1 );
20-
domEqual( "#tabs2", function( done ) {
24+
assert.domEqual( "#tabs2", function( done ) {
2125
var element = $( "#tabs2" ).tabs({
2226
load: function() {
2327
setTimeout(function() {
@@ -283,4 +287,4 @@ test( "widget", function() {
283287
strictEqual( widgetElement[ 0 ], element[ 0 ], "same element" );
284288
});
285289

286-
}( jQuery ) );
290+
} );

tests/unit/tabs/tabs_options.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./tabs_test_helpers",
4+
"ui/tabs"
5+
], function( $, tabsTestHelpers ) {
26

3-
var disabled = TestHelpers.tabs.disabled,
4-
equalHeight = TestHelpers.tabs.equalHeight,
5-
state = TestHelpers.tabs.state;
7+
var disabled = tabsTestHelpers.disabled,
8+
equalHeight = tabsTestHelpers.equalHeight,
9+
state = tabsTestHelpers.state;
610

711
module( "tabs: options" );
812

@@ -367,4 +371,4 @@ asyncTest( "hide and show - animation", function() {
367371
element.tabs( "option", "active", 1 );
368372
});
369373

370-
}( jQuery ) );
374+
} );

tests/unit/tabs/tabs_test_helpers.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
TestHelpers.tabs = {
1+
define( function() {
2+
3+
return {
24
disabled: function( tabs, state ) {
35
var expected, actual,
46
internalState = tabs.tabs( "option", "disabled" );
@@ -64,3 +66,5 @@ TestHelpers.tabs = {
6466
deepEqual( actual, expected );
6567
}
6668
};
69+
70+
} );

0 commit comments

Comments
 (0)