Skip to content

Commit 6fb584e

Browse files
felix9scottgonzalez
authored andcommitted
Fixes #6979 - Several components are leaking variables into the global scope.
1 parent c45911c commit 6fb584e

5 files changed

+5
-6
lines changed

ui/jquery.effects.core.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ $.extend($.effects, {
419419
setTransition: function(element, list, factor, value) {
420420
value = value || {};
421421
$.each(list, function(i, x){
422-
unit = element.cssUnit(x);
422+
var unit = element.cssUnit(x);
423423
if (unit[0] > 0) value[x] = unit[0] * factor + unit[1];
424424
});
425425
return value;

ui/jquery.effects.pulsate.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
$.effects.pulsate = function(o) {
1616
return this.queue(function() {
1717
var elem = $(this),
18-
mode = $.effects.setMode(elem, o.options.mode || 'show');
19-
times = ((o.options.times || 5) * 2) - 1;
18+
mode = $.effects.setMode(elem, o.options.mode || 'show'),
19+
times = ((o.options.times || 5) * 2) - 1,
2020
duration = o.duration ? o.duration / 2 : $.fx.speeds._default / 2,
2121
isVisible = elem.is(':visible'),
2222
animateTo = 0;

ui/jquery.effects.scale.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ $.effects.size = function(o) {
140140
hProps = hProps.concat(['marginLeft','marginRight']); // Add margins
141141
props2 = props.concat(vProps).concat(hProps); // Concat
142142
el.find("*[width]").each(function(){
143-
child = $(this);
143+
var child = $(this);
144144
if (restore) $.effects.save(child, props2);
145145
var c_original = {height: child.height(), width: child.width()}; // Save original
146146
child.from = {height: c_original.height * factor.from.y, width: c_original.width * factor.from.x};

ui/jquery.ui.autocomplete.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ $.widget("ui.menu", {
594594
}
595595

596596
var base = this.active.offset().top,
597-
height = this.element.height();
597+
height = this.element.height(),
598598
result = this.element.children(".ui-menu-item").filter(function() {
599599
var close = $(this).offset().top - base + height - $(this).height();
600600
// TODO improve approximation

ui/jquery.ui.tabs.js

-1
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,6 @@ $.extend( $.ui.tabs.prototype, {
733733
}
734734
}
735735
: function( e ) {
736-
t = o.selected;
737736
rotate();
738737
});
739738

0 commit comments

Comments
 (0)