Skip to content

Commit 71c0562

Browse files
committed
Selectable: Remove uses of self var; use that var.
1 parent 84c8ba0 commit 71c0562

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

ui/jquery.ui.selectable.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ $.widget("ui.selectable", $.ui.mouse, {
2424
tolerance: 'touch'
2525
},
2626
_create: function() {
27-
var self = this;
27+
var that = this;
2828

2929
this.element.addClass("ui-selectable");
3030

@@ -33,7 +33,7 @@ $.widget("ui.selectable", $.ui.mouse, {
3333
// cache selectee children based on filter
3434
var selectees;
3535
this.refresh = function() {
36-
selectees = $(self.options.filter, self.element[0]);
36+
selectees = $(that.options.filter, that.element[0]);
3737
selectees.addClass("ui-selectee");
3838
selectees.each(function() {
3939
var $this = $(this);
@@ -75,7 +75,7 @@ $.widget("ui.selectable", $.ui.mouse, {
7575
},
7676

7777
_mouseStart: function(event) {
78-
var self = this;
78+
var that = this;
7979

8080
this.opos = [event.pageX, event.pageY];
8181

@@ -110,7 +110,7 @@ $.widget("ui.selectable", $.ui.mouse, {
110110
selectee.$element.addClass('ui-unselecting');
111111
selectee.unselecting = true;
112112
// selectable UNSELECTING callback
113-
self._trigger("unselecting", event, {
113+
that._trigger("unselecting", event, {
114114
unselecting: selectee.element
115115
});
116116
}
@@ -128,11 +128,11 @@ $.widget("ui.selectable", $.ui.mouse, {
128128
selectee.selected = doSelect;
129129
// selectable (UN)SELECTING callback
130130
if (doSelect) {
131-
self._trigger("selecting", event, {
131+
that._trigger("selecting", event, {
132132
selecting: selectee.element
133133
});
134134
} else {
135-
self._trigger("unselecting", event, {
135+
that._trigger("unselecting", event, {
136136
unselecting: selectee.element
137137
});
138138
}
@@ -143,7 +143,7 @@ $.widget("ui.selectable", $.ui.mouse, {
143143
},
144144

145145
_mouseDrag: function(event) {
146-
var self = this;
146+
var that = this;
147147
this.dragged = true;
148148

149149
if (this.options.disabled)
@@ -159,7 +159,7 @@ $.widget("ui.selectable", $.ui.mouse, {
159159
this.selectees.each(function() {
160160
var selectee = $.data(this, "selectable-item");
161161
//prevent helper from being selected if appendTo: selectable
162-
if (!selectee || selectee.element == self.element[0])
162+
if (!selectee || selectee.element == that.element[0])
163163
return;
164164
var hit = false;
165165
if (options.tolerance == 'touch') {
@@ -182,7 +182,7 @@ $.widget("ui.selectable", $.ui.mouse, {
182182
selectee.$element.addClass('ui-selecting');
183183
selectee.selecting = true;
184184
// selectable SELECTING callback
185-
self._trigger("selecting", event, {
185+
that._trigger("selecting", event, {
186186
selecting: selectee.element
187187
});
188188
}
@@ -202,7 +202,7 @@ $.widget("ui.selectable", $.ui.mouse, {
202202
selectee.unselecting = true;
203203
}
204204
// selectable UNSELECTING callback
205-
self._trigger("unselecting", event, {
205+
that._trigger("unselecting", event, {
206206
unselecting: selectee.element
207207
});
208208
}
@@ -215,7 +215,7 @@ $.widget("ui.selectable", $.ui.mouse, {
215215
selectee.$element.addClass('ui-unselecting');
216216
selectee.unselecting = true;
217217
// selectable UNSELECTING callback
218-
self._trigger("unselecting", event, {
218+
that._trigger("unselecting", event, {
219219
unselecting: selectee.element
220220
});
221221
}
@@ -227,7 +227,7 @@ $.widget("ui.selectable", $.ui.mouse, {
227227
},
228228

229229
_mouseStop: function(event) {
230-
var self = this;
230+
var that = this;
231231

232232
this.dragged = false;
233233

@@ -238,7 +238,7 @@ $.widget("ui.selectable", $.ui.mouse, {
238238
selectee.$element.removeClass('ui-unselecting');
239239
selectee.unselecting = false;
240240
selectee.startselected = false;
241-
self._trigger("unselected", event, {
241+
that._trigger("unselected", event, {
242242
unselected: selectee.element
243243
});
244244
});
@@ -248,7 +248,7 @@ $.widget("ui.selectable", $.ui.mouse, {
248248
selectee.selecting = false;
249249
selectee.selected = true;
250250
selectee.startselected = true;
251-
self._trigger("selected", event, {
251+
that._trigger("selected", event, {
252252
selected: selectee.element
253253
});
254254
});

0 commit comments

Comments
 (0)