Slider: Fix to restrict handle values when set programmatically.

Fixes #3762 - Slider: handles not restricted properly when set programmatically

Author: dekajp

ui/slider.js

@@ -67,6 +67,7 @@ return $.widget( "ui.slider", $.ui.mouse, {
 		this._detectOrientation();
 		this._mouseInit();
 		this._calculateNewMax();
+		this._cleanValues();
 
 		this.element
 			.addClass( "ui-slider" +
@@ -159,12 +160,28 @@ return $.widget( "ui.slider", $.ui.mouse, {
 
 	_cleanValues: function( index, newValue ) {
 		var values,
-			i = 0 ;
+			i = 0;
+
+		if ( this.options.range === true ){
+			if ( arguments.length === 2 ) {
+				values = this.options.values;
+				if ( index === 0 && newValue < this._valueMin() ){
+					newValue = this._valueMin();
+				}else if ( index === 1 && newValue > this._valueMax() ){
+					newValue = this._valueMax();
+				}
+
+				if ( index === 0 && newValue > values[ 1 ] ) {
+					newValue = values[ 1 ];
+				}else if ( index === 1 && newValue < values[ 0 ] ) {
+					newValue = values[ 0 ];
+				}
+				return newValue;
+			}
 
-		if ( $.isArray( arguments[ 0 ] ) ) {
 			values = arguments[ 0 ] || this.options.values;
 			if ( values ) {
-				for ( ; i < values.length; i++ ){
+				for ( ; i < values.length; i++ ) {
 					if ( values[ i ] < this._valueMin() ) {
 						values[ i ] = this._valueMin();
 					}
@@ -176,26 +193,19 @@ return $.widget( "ui.slider", $.ui.mouse, {
 				if ( values[ 0 ] > values[ 1 ] ) {
 					values[ 1 ] = values[ 0 ];
 				}
-				return values;
-			}
-		}
-
-		if ( arguments.length > 1 ) {
-			values = this.options.values;
-			if ( index === 0 && newValue < this._valueMin() ){
-				newValue = this._valueMin();
-			}else if ( index === 1 && newValue > this._valueMax() ){
-				newValue = this._valueMax();
-			}
 
-			if ( this.options.range === true && values.length === 2 ) {
-				if ( index === 0 && newValue > values[ index + 1 ] ) {
-					newValue = values[ index + 1 ];
-				}else if ( index === 1 && newValue < values[ index - 1 ] ) {
-					newValue = values[ index - 1 ];
+				if ( arguments[ 0 ] ){
+					return values;
+				} else {
+					this.options.values = values;
 				}
 			}
-			return newValue;
+		} else {
+			if ( $.isArray( arguments[ 0 ] ) ) {
+				return arguments[0];
+			} else {
+				return newValue;
+			}
 		}
 	},
 
@@ -465,7 +475,6 @@ return $.widget( "ui.slider", $.ui.mouse, {
 				this._refreshValue();
 			} else {
 				if ( this.options.values && this.options.values.length ) {
-					this.options.values = this._cleanValues( this.options.values );
 					return this._values( index );
 				} else {
 					return this.value();