Skip to content

Commit 993d37a

Browse files
committed
Popup: Rename open flag to isOpen to avoid name conflict with open method.
1 parent 116acb4 commit 993d37a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/visual/menu/popup.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ $.widget( "ui.popup", {
4545
},
4646
click: function( event ) {
4747
event.preventDefault();
48-
if (this.open) {
48+
if (this.isOpen) {
4949
// let it propagate to close
5050
return;
5151
}
@@ -75,7 +75,7 @@ $.widget( "ui.popup", {
7575

7676
this._bind(document, {
7777
click: function( event ) {
78-
if (this.open && !$(event.target).closest(".ui-popup").length) {
78+
if (this.isOpen && !$(event.target).closest(".ui-popup").length) {
7979
this.close( event );
8080
}
8181
}
@@ -116,7 +116,7 @@ $.widget( "ui.popup", {
116116
// take trigger out of tab order to allow shift-tab to skip trigger
117117
this.options.trigger.attr("tabindex", -1);
118118

119-
this.open = true;
119+
this.isOpen = true;
120120
this._trigger( "open", event );
121121
},
122122

@@ -128,7 +128,7 @@ $.widget( "ui.popup", {
128128

129129
this.options.trigger.attr("tabindex", 0);
130130

131-
this.open = false;
131+
this.isOpen = false;
132132
this._trigger( "close", event );
133133
}
134134

0 commit comments

Comments
 (0)